Released memory retained by ExchangeSource #11097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzebing
reviewed
Feb 18, 2022
Comment on lines
+496
to
+499
| // If the data source has been closed in a meantime reset memory usage back to 0 | ||
| if (closed) { | ||
| systemMemoryContext.setBytes(0); | ||
| } |
There was a problem hiding this comment.
Why is this check needed? systemMemoryContext.setBytes(0); will always be executed in the finally block of close(), right?
There was a problem hiding this comment.
Yes, but pollPage and close can be called concurrently. It is possible that close will set the memory reservation to 0 while the pollPage will reset it back to a non zero value
linzebing
approved these changes
Feb 18, 2022
|
Typo in commit message "Released" -> "Release" |
losipiuk
reviewed
Feb 18, 2022
| // It is modified (assigned to null) when the ExchangeOperator is closed. | ||
| // It doesn't have to be declared as volatile as the nullification of this variable doesn't have to be immediately visible to other threads. | ||
| // However since close can be called at any moment this variable has to be accessed in a safe way (avoiding "check-then-use"). | ||
| private ExchangeSource exchangeSource; |
There was a problem hiding this comment.
There two separate issues here. One improving GC and another is ensuring memory pool accounting is fine. It would be nice to have separated commits for them.
losipiuk
approved these changes
Feb 18, 2022
arhimondr
force-pushed
the
nullify-exchange-source
branch
from
b7d7dda to
d023e5b
Compare
|
CI: #11140 |
|
CI: #4936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid retaining memory used by ExchangeSource more than necessary
Improvement
Core engine
Non user visible improvement
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: