Fix race condition in DirectExchangeClient #11088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Feb 17, 2022
core/trino-main/src/main/java/io/trino/operator/DirectExchangeClient.java
Show resolved
Hide resolved
losipiuk
approved these changes
Feb 17, 2022
arhimondr
force-pushed
the
memory-account-race-condition-exchange-client
branch
from
d1b9182 to
0e86ca1
Compare
|
Updated |
A race condition can occur when the client is closed while still being active (e.g.: early termination due to LIMIT). It may happen that the memory context is updated after close and then never set back to 0.
arhimondr
force-pushed
the
memory-account-race-condition-exchange-client
branch
from
0e86ca1 to
6ffc89f
Compare
losipiuk
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A race condition can occur when the client is closed while still being
active (e.g.: early termination due to LIMIT). It may happen that the
memory context is updated after close and then never set back to 0.
Bug
Core
Users may see queries retaining memory after completion
Related issues, pull requests, and links
#11030
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: