Add check for used Cassandra partition columns #11082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Feb 17, 2022
| @@ -69,8 +71,13 @@ public CassandraPartitionResult getPartitions(CassandraTableHandle cassandraTabl | |||
| remainingTupleDomain = tupleDomain; | |||
| } | |||
| else { | |||
| List<ColumnHandle> partitionColumns = ImmutableList.copyOf(partitionKeys); | |||
| remainingTupleDomain = tupleDomain.filter((column, domain) -> !partitionColumns.contains(column)); | |||
| ImmutableSet<ColumnHandle> usedPartitionColumns = partitions.stream() | |||
losipiuk
reviewed
Feb 17, 2022
| remainingTupleDomain = tupleDomain.filter((column, domain) -> !partitionColumns.contains(column)); | ||
| ImmutableSet<ColumnHandle> usedPartitionColumns = partitions.stream() | ||
| .flatMap(partition -> Optional.ofNullable(partition.getTupleDomain()).stream() | ||
| .flatMap(tD -> tD.getDomains().stream()) |
There was a problem hiding this comment.
it clashes with the other variables, but domain is ok.
There was a problem hiding this comment.
I've got another idea, take a look now please.
s2lomon
force-pushed
the
s2lomon/cassandra-aggregation-pushdown-bug
branch
from
dba44d1 to
078b187
Compare
ebyhr
approved these changes
Feb 18, 2022
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraTestingUtils.java
Outdated
Show resolved
Hide resolved
Thank to this we don't drop partition Predicates, that does not match in Cassandra, totally out of the query. This prediction droping results in returning to many rows.
s2lomon
force-pushed
the
s2lomon/cassandra-aggregation-pushdown-bug
branch
from
078b187 to
369a251
Compare
|
Merged, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to this we don't drop partition Predicates, that does not
match in Cassandra, totally out of the query. As it is today results in
returning some rows when none should be returned.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: