Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of list in access control docs #11073

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Feb 16, 2022

Description

Fixes bulleted list at https://trino.io/docs/current/security/file-system-access-control.html#visibility

Is this change a fix, improvement, new feature, refactoring, or other?

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@hashhar hashhar requested a review from mosabua February 16, 2022 20:41
@cla-bot cla-bot bot added the cla-signed label Feb 16, 2022
@github-actions github-actions bot added the docs label Feb 16, 2022
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think L345 in Session property rules section needs fix as well.

@hashhar hashhar force-pushed the hashhar/fix-doc-render branch from 9136ec1 to 054270e Compare February 17, 2022 07:05
@hashhar
Copy link
Member Author

hashhar commented Feb 17, 2022

Thanks for catching that @ebyhr. Fixed as well. I couldn't find any other such occurrences within this file. (searching for any * not at beginning of line).

@hashhar hashhar merged commit 852f8c7 into trinodb:master Feb 17, 2022
@hashhar hashhar deleted the hashhar/fix-doc-render branch February 17, 2022 17:17
@github-actions github-actions bot added this to the 372 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants