Avoid volatile writes for empty responses in HttpPageBufferClient #11069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhimondr
approved these changes
Feb 16, 2022
pettyjamesm
force-pushed
the
avoid-volatile-buffer-stats-writes
branch
from
70ae98d to
70ce312
Compare
pettyjamesm
force-pushed
the
avoid-volatile-buffer-stats-writes
branch
from
70ce312 to
b8f44ea
Compare
losipiuk
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor modification to the behavior of
HttpPageBufferClientto avoid volatile writes to stats fields when no update is necessary, and to do so outside of a synchronized section.This is a minor improvement to
HttpPageBufferClientThis change affects the core engine only
No description to a non-technical end user should be necessary
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: