Disable cache sharing when cache is disabled in JDBC connectors #11068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/cached-concurrent-failure
branch
4 times, most recently
from
78fab5a to
1f4ed5d
Compare
losipiuk
reviewed
Feb 17, 2022
lib/trino-collect/src/main/java/io/trino/collect/cache/EvictableCacheBuilder.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Feb 17, 2022
lib/trino-collect/src/test/java/io/trino/collect/cache/TestEvictableCache.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Feb 17, 2022
findepi
force-pushed
the
findepi/cached-concurrent-failure
branch
2 times, most recently
from
3be52e4 to
c8170e6
Compare
findepi
changed the title
This disables opportunistic sharing of results (and failures) between threads when global cache (in `CachingJdbcClient`) is disabled. This fixes usages going through `EvictableCacheBuilder`. Other cache usages are to be addressed later.
findepi
force-pushed
the
findepi/cached-concurrent-failure
branch
from
c8170e6 to
ffbcd63
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables opportunistic sharing of results (and failures) between
threads when cache is disabled.
This fixes usages going through
EvictableCacheBuilder. Other cacheusages are to be addressed later.
Relates to: #11067