Fix listTables to include views #11063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/list-ice-view
branch
2 times, most recently
from
4543431 to
f99dfed
Compare
findepi
changed the title
This makes `system.jdbc.columns` assertions consistent with preceding `information_schema.columns` assertions.
findepi
force-pushed
the
findepi/list-ice-view
branch
from
f99dfed to
a083752
Compare
|
Can we rename listTables to listRelations to avoid confusion ? It's easy to miss that code comment about listTables contract and assume that it is meant to list tables. |
|
Do we need an update to BlackHoleMetadata as well ? |
findepi
force-pushed
the
findepi/list-ice-view
branch
from
a083752 to
e2c643d
Compare
fixed
out of scope |
hashhar
reviewed
Feb 18, 2022
whatever |
hashhar
approved these changes
Feb 18, 2022
losipiuk
reviewed
Feb 23, 2022
| @@ -441,12 +444,16 @@ public void dropView(ConnectorSession session, SchemaTableName schemaViewName) | |||
| { | |||
| // Filter on PRESTO_VIEW_COMMENT to distinguish from materialized views | |||
losipiuk
approved these changes
Feb 23, 2022
Per `ConnectorMetadata.listTables` contract, this should include views and materialized views. Make Iceberg implementation follow the contract. This fixes `IcebergMetadata`, `AccumuloMetadata`, `RaptorMetadata` and `BlackHoleMetadata. The `HiveMetadata` was correct and other connectors do not support views currently. This also fixes `system.jdbc.tables` and `system.jdbc.columns` -- Iceberg views were not included in these tables.
findepi
force-pushed
the
findepi/list-ice-view
branch
from
e2c643d to
2c8bdf7
Compare
Closed
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per
ConnectorMetadata.listTablescontract, this should include viewsand materialized views. Make Iceberg implementation follow the contract.
This fixes
IcebergMetadata,AccumuloMetadataandRaptorMetadata.The
HiveMetadatawas correct and other connectors do not support viewscurrently.
This also fixes
system.jdbc.tablesandsystem.jdbc.columns--Iceberg views were not included in these tables.
Fixes #11060