Support incremental maven builds in PTL #11061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/support-incremental-maven-builds-in-ptl-30c2ea
branch
from
86181d4 to
6ea94ea
Compare
|
phoenix failure might be unrelated |
| if which mvnd >/dev/null; then | ||
| # Using mvnd here can save more than 2 seconds compared to ./mvnw startup cost. This is especially important | ||
| # when invoking inspection commands like --help, env list, etc. | ||
| trino_version=$(mvnd -B help:evaluate -Dexpression=pom.version -q -DforceStdout --raw-streams) |
There was a problem hiding this comment.
Would it make sense to skip this if there's only one launcher jar?
There was a problem hiding this comment.
Not sure. What if the launcher jar is outdated?
|
Looks fine. Thanks! |
`mvn install` is typically faster than `mvn clean install`, but it leaves previous launcher jar in the target/. Let bin/ptl pick it up nicely. This also prevents the script from picking up a way-too-old launcher jar, i.e. after project version change.
findepi
force-pushed
the
findepi/support-incremental-maven-builds-in-ptl-30c2ea
branch
from
6ea94ea to
8ee5843
Compare
nineinchnick
approved these changes
Feb 20, 2022
findepi
deleted the
findepi/support-incremental-maven-builds-in-ptl-30c2ea
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn installis typically faster thanmvn clean install, but itleaves previous launcher jar in the target/. Let bin/ptl pick it up
nicely.
This also prevents the script from picking up a way-too-old launcher
jar, i.e. after project version change.