Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sql type tests for cassandra #11028

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Add sql type tests for cassandra #11028

merged 2 commits into from
Apr 27, 2022

Conversation

tangjiangling
Copy link
Member

@tangjiangling tangjiangling commented Feb 13, 2022 •
edited by ebyhr
Loading

Description

Fix part of the issue raised by #10860.

General information

Is this change a fix, improvement, new feature, refactoring, or other?

Improve tests in Cassandra(TestCassandraConnectorTest).

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

N/A.

How would you describe this change to a non-technical end user or system administrator?

N/A.

Related issues, pull requests, and links

Fixes #10860

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Feb 13, 2022
@tangjiangling tangjiangling requested a review from ebyhr February 13, 2022 22:26
@tangjiangling
Copy link
Member Author

WIP, there are still two issues raised by #10860 that are not fixed, I will add new commits to fix these two issues by tonight.

@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from cf2ba18 to 183b13a Compare February 15, 2022 00:52
@tangjiangling
Copy link
Member Author

Updated. But when I run TestCassandraConnectorTest locally I get a strange error.

No tests found in the class "io.trino.plugin.cassandra.TestCassandraConnectorTest"

@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from 183b13a to d39d3c9 Compare February 15, 2022 01:04
@tangjiangling
Copy link
Member Author

CI https://github.com/trinodb/trino/runs/5193412813?check_suite_focus=true

I'll take a look.

@tangjiangling
Copy link
Member Author

No tests found in the class "io.trino.plugin.cassandra.TestCassandraConnectorTest"

Fixed, ignore.

@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from d39d3c9 to 73edc0c Compare February 15, 2022 02:26
@tangjiangling
Copy link
Member Author

@ebyhr Updated, you can review now :)

@tangjiangling tangjiangling changed the title [WIP] Add sql type tests for cassandra Add sql type tests for cassandra Feb 15, 2022
@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from 73edc0c to 6e0c226 Compare February 15, 2022 04:39
@ebyhr ebyhr added the maintenance Project maintenance task label Feb 15, 2022
ebyhr
ebyhr reviewed Feb 25, 2022
View reviewed changes
@tangjiangling
Copy link
Member Author

Ah, thanks for the careful review, I'll update this PR later today.

@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from 6e0c226 to 11f09f1 Compare February 26, 2022 10:33
@tangjiangling
Copy link
Member Author

Updated.

@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from 11f09f1 to 872be4a Compare March 25, 2022 12:12
@tangjiangling
Copy link
Member Author

I'll add tests for unsupported types (e.g. tinyint, smallint, int, bigint) in a separate PR

@tangjiangling tangjiangling added the no-release-notes This pull request does not require release notes entry label Mar 25, 2022
@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from 872be4a to 08eac19 Compare April 24, 2022 12:47
@tangjiangling
Copy link
Member Author

(Rebased from master)

@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from 08eac19 to 181b12b Compare April 25, 2022 03:54
@tangjiangling
Copy link
Member Author

AC

@tangjiangling tangjiangling mentioned this pull request Apr 25, 2022
Closed
@tangjiangling
Copy link
Member Author

I'll add tests for unsupported types (e.g. tinyint, smallint, int, bigint) in a separate PR

#12115

@tangjiangling tangjiangling force-pushed the add-sql-type-tests-for-cassandra branch from 181b12b to b7a5ed9 Compare April 26, 2022 19:36
@ebyhr ebyhr merged commit a5c8f30 into trinodb:master Apr 27, 2022
@github-actions github-actions bot added this to the 379 milestone Apr 27, 2022
@tangjiangling tangjiangling deleted the add-sql-type-tests-for-cassandra branch April 27, 2022 03:53
@mosabua mosabua mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed maintenance Project maintenance task no-release-notes This pull request does not require release notes entry
Milestone
379
Development

Successfully merging this pull request may close these issues.

Add SqlDataTypeTest to Cassandra connector
2 participants
@tangjiangling @ebyhr