Implement remaining TODOs from TIMESTAMP semantic fix #10963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
commented
Feb 6, 2022
| @@ -577,7 +582,6 @@ public void testAssignUniqueId() | |||
| @Test | |||
| public void testAtTimeZone() | |||
| { | |||
| // TODO the expected values here are non-sensical due to https://github.com/trinodb/trino/issues/37 | |||
There was a problem hiding this comment.
The semantics of these values are covered extensively by https://github.com/trinodb/trino/blob/master/core/trino-main/src/test/java/io/trino/operator/scalar/timestamp/TestTimestamp.java#L2639
electrum
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup lingering TODOs from #37
General information
Is this change a fix, improvement, new feature, refactoring, or other?
just tests
Is this a change to the core query engine, a connector, client library, or the
SPI interfaces (be specific)?
tests
How would you describe this change to a non-technical end user or system
administrator?
N/A
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: