Ensure ExchangeClient is always properly closed #10950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhimondr
force-pushed
the
close-exchange-client
branch
8 times, most recently
from
206c61e to
821761d
Compare
electrum
reviewed
Feb 7, 2022
| @@ -450,6 +450,8 @@ private synchronized QueryResults getNextResult(long token, UriInfo uriInfo, Dat | |||
| } | |||
| else { | |||
| nextToken = OptionalLong.empty(); | |||
| // the client is not coming back, make sure the exchangeClient is closed | |||
There was a problem hiding this comment.
Shouldn't this be handled above by closeExchangeClientIfNecessary()?
There was a problem hiding this comment.
closeExchangeClientIfNecessary only closes the client if a query fails or if a query returns no results (e.g.: a DDL query)
arhimondr
force-pushed
the
close-exchange-client
branch
14 times, most recently
from
c4afc59 to
98507e9
Compare
arhimondr
changed the title
The exchange client used to pull query results may not get closed if a query is abandoned or even when query finished successfully.
arhimondr
force-pushed
the
close-exchange-client
branch
from
98507e9 to
b2fbe05
Compare
linzebing
approved these changes
Feb 9, 2022
losipiuk
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The exchange client used to pull query results may not get closed if a
query is abandoned or even when query finished successfully.
General information
This is a very old problem that didn't manifest itself until #10507. Now since the
ExchangeClientmay create files when spooling it is required for the temporary data to be properly disposed upon query completion.Related issues, pull requests, and links
#10507
Documentation
No documentation is needed.
Release notes
No release notes entries required.