Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark tests that write using Hive as flaky in TestHiveStorageFormats #10926

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Mark tests that write using Hive as flaky in TestHiveStorageFormats #10926

merged 1 commit into from
Feb 3, 2022

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Feb 3, 2022

These tests sometimes fail with "Error committing write to Hive".

@hashhar
Mark tests that write using Hive as flaky in TestHiveStorageFormats
9f15917 
These tests sometimes fail with "Error committing write to Hive".
@hashhar hashhar requested a review from findepi February 3, 2022 08:10
@cla-bot cla-bot bot added the cla-signed label Feb 3, 2022
@hashhar
Copy link
Member Author

hashhar commented Feb 3, 2022

base jdbc concurrency cc: @grantatspothero @hashhar

io.trino.plugin.jdbc.TestCachingJdbcClient.testConcurrentSchemaCreateAndDrop  Time elapsed: 0.087 s  <<< FAILURE!
com.google.common.util.concurrent.UncheckedExecutionException: 
io.trino.spi.TrinoException: General error: "java.lang.NullPointerException"; SQL statement:
SELECT SCHEMA_NAME TABLE_SCHEM, CATALOG_NAME TABLE_CATALOG,  IS_DEFAULT FROM INFORMATION_SCHEMA.SCHEMATA WHERE CATALOG_NAME LIKE ? ESCAPE ? AND SCHEMA_NAME LIKE ? ESCAPE ? ORDER BY SCHEMA_NAME [50000-200]
	at com.google.common.util.concurrent.Futures.wrapAndThrowUnchecked(Futures.java:1396)
	at com.google.common.util.concurrent.Futures.getUnchecked(Futures.java:1382)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at io.trino.plugin.jdbc.TestCachingJdbcClient.testConcurrentSchemaCreateAndDrop(TestCachingJdbcClient.java:621)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
	at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: io.trino.spi.TrinoException: General error: "java.lang.NullPointerException"; SQL statement:
SELECT SCHEMA_NAME TABLE_SCHEM, CATALOG_NAME TABLE_CATALOG,  IS_DEFAULT FROM INFORMATION_SCHEMA.SCHEMATA WHERE CATALOG_NAME LIKE ? ESCAPE ? AND SCHEMA_NAME LIKE ? ESCAPE ? ORDER BY SCHEMA_NAME [50000-200]
	at io.trino.plugin.jdbc.BaseJdbcClient.listSchemas(BaseJdbcClient.java:155)
	at io.trino.plugin.jdbc.BaseJdbcClient.getSchemaNames(BaseJdbcClient.java:132)
	at io.trino.plugin.jdbc.ForwardingJdbcClient.getSchemaNames(ForwardingJdbcClient.java:71)
	at io.trino.plugin.jdbc.CachingJdbcClient.lambda$getSchemaNames$1(CachingJdbcClient.java:143)
	at io.trino.plugin.base.cache.EvictableCache.get(EvictableCache.java:109)
	at io.trino.plugin.jdbc.CachingJdbcClient.get(CachingJdbcClient.java:679)
	at io.trino.plugin.jdbc.CachingJdbcClient.getSchemaNames(CachingJdbcClient.java:143)
	at io.trino.plugin.jdbc.TestCachingJdbcClient.lambda$testConcurrentSchemaCreateAndDrop$44(TestCachingJdbcClient.java:614)
	... 4 more
Caused by: org.h2.jdbc.JdbcSQLNonTransientException: General error: "java.lang.NullPointerException"; SQL statement:
SELECT SCHEMA_NAME TABLE_SCHEM, CATALOG_NAME TABLE_CATALOG,  IS_DEFAULT FROM INFORMATION_SCHEMA.SCHEMATA WHERE CATALOG_NAME LIKE ? ESCAPE ? AND SCHEMA_NAME LIKE ? ESCAPE ? ORDER BY SCHEMA_NAME [50000-200]
	at org.h2.message.DbException.getJdbcSQLException(DbException.java:505)
	at org.h2.message.DbException.getJdbcSQLException(DbException.java:429)
	at org.h2.message.DbException.get(DbException.java:194)
	at org.h2.message.DbException.convert(DbException.java:347)
	at org.h2.command.Command.executeQuery(Command.java:212)
	at org.h2.jdbc.JdbcPreparedStatement.executeQuery(JdbcPreparedStatement.java:114)
	at org.h2.jdbc.JdbcDatabaseMetaData.getSchemas(JdbcDatabaseMetaData.java:3176)
	at io.trino.plugin.jdbc.BaseJdbcClient.listSchemas(BaseJdbcClient.java:143)
	... 11 more
Caused by: java.lang.NullPointerException
	at org.h2.table.MetaTable.generateRows(MetaTable.java:1515)
	at org.h2.index.MetaIndex.find(MetaIndex.java:51)
	at org.h2.index.BaseIndex.find(BaseIndex.java:148)
	at org.h2.index.IndexCursor.find(IndexCursor.java:163)
	at org.h2.table.TableFilter.next(TableFilter.java:498)
	at org.h2.command.dml.Select$LazyResultQueryFlat.fetchNextRow(Select.java:1843)
	at org.h2.result.LazyResult.hasNext(LazyResult.java:101)
	at org.h2.result.LazyResult.next(LazyResult.java:60)
	at org.h2.command.dml.Select.queryFlat(Select.java:737)
	at org.h2.command.dml.Select.queryWithoutCache(Select.java:844)
	at org.h2.command.dml.Query.queryWithoutCacheLazyCheck(Query.java:201)
	at org.h2.command.dml.Query.query(Query.java:489)
	at org.h2.command.dml.Query.query(Query.java:451)
	at org.h2.command.CommandContainer.query(CommandContainer.java:285)
	at org.h2.command.Command.executeQuery(Command.java:195)
	... 14 more

Iceberg DF cc: @raunaqmorarka

Error:  io.trino.plugin.iceberg.TestIcebergParquetConnectorTest.testLocalDynamicFilteringWithSelectiveBuildSizeJoin  Time elapsed: 0.791 s  <<< FAILURE!
java.lang.AssertionError: 

Expecting:
 <2L>
to be equal to:
 <3L>
but was not.
	at io.trino.plugin.iceberg.BaseIcebergConnectorTest.testLocalDynamicFilteringWithSelectiveBuildSizeJoin(BaseIcebergConnectorTest.java:2743)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

Unrelated failures. Merging.

@hashhar hashhar merged commit 3efbce7 into trinodb:master Feb 3, 2022
@hashhar hashhar deleted the hashhar/flaky-hive-storage-format branch February 3, 2022 11:55
@findepi
Copy link
Member

findepi commented Feb 3, 2022

base jdbc concurrency cc: @grantatspothero @hashhar

io.trino.plugin.jdbc.TestCachingJdbcClient.testConcurrentSchemaCreateAndDrop  Time elapsed: 0.087 s  <<< FAILURE!
com.google.common.util.concurrent.UncheckedExecutionException: 
io.trino.spi.TrinoException: General error: "java.lang.NullPointerException"; SQL statement:

@hashhar this is @kokosing 's test i added in #10544
please file an issue

Iceberg DF cc: @raunaqmorarka

Error:  io.trino.plugin.iceberg.TestIcebergParquetConnectorTest.testLocalDynamicFilteringWithSelectiveBuildSizeJoin  Time elapsed: 0.791 s  <<< FAILURE!
java.lang.AssertionError:

@hashhar i don't see an issue for this, is there one?

@hashhar
Copy link
Member Author

hashhar commented Feb 3, 2022

Created #10932 and #10933 .

@github-actions github-actions bot added this to the 370 milestone Feb 3, 2022
@mosabua mosabua mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
370
Development

Successfully merging this pull request may close these issues.
2 participants
@hashhar @findepi