Simplify extensability of BaseHiveConnectorTest #10753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
changed the title
losipiuk
force-pushed
the
lo/BaseConnectorTest-extensible
branch
from
2cd6a75 to
d4a23c6
Compare
|
cc: @arhimondr |
Praveen2112
approved these changes
Jan 24, 2022
...ino-hive/src/test/java/io/trino/plugin/hive/TestHiveFaultTolerantExecutionConnectorTest.java
Show resolved
Hide resolved
findepi
approved these changes
Jan 24, 2022
...ino-hive/src/test/java/io/trino/plugin/hive/TestHiveFaultTolerantExecutionConnectorTest.java
Show resolved
Hide resolved
| @@ -14,12 +14,15 @@ | |||
| package io.trino.plugin.hive; | |||
|
|
|||
| import com.google.common.collect.ImmutableMap; | |||
| import io.trino.testing.QueryRunner; | |||
|
|
|||
| public class TestHivePipelinedExecutionConnectorTest | |||
There was a problem hiding this comment.
what does "pipelined execution" mean here?
it this is "test hive with defaults", let's call the class just TestHiveConnectorTest
There was a problem hiding this comment.
Yeah - effectively it is with defaults (no failure recovery). I will rename in a separate PR after this gets merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.