Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable testRenameSchema in ClickHouse #10733

Merged

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jan 21, 2022

Relates to #10653

@cla-bot cla-bot bot added the cla-signed label Jan 21, 2022
@@ -29,4 +30,12 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
return super.hasBehavior(connectorBehavior);
}
}

// TODO (https://github.com/trinodb/trino/issues/10653) Disable until fixing the flaky test issue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would @Flaky help?

@ebyhr
Copy link
Member Author

ebyhr commented Jan 22, 2022

Sadly, @Flaky didn't help:

2022-01-22T02:15:26.5976518Z 2022-01-21T20:15:26.579-0600 WARNING Test io.trino.plugin.clickhouse.TestClickHouseLatestConnectorSmokeTest::testRenameSchema attempt 1 failed, retrying...,
2022-01-22T02:15:26.5977504Z java.lang.RuntimeException: ClickHouse exception, code: 62, host: localhost, port: 49165; Code: 62, e.displayText() = DB::Exception: Syntax error: failed at position 8: DATABASE "test_rename_schema_10ql5o2g2p" TO "test_rename_schema_10ql5o2g2p_renamed". Expected TABLE (version 20.3.12.112 (official build))
2022-01-22T02:15:26.5977983Z 
2022-01-22T02:15:26.5982220Z 	at io.trino.testing.AbstractTestingTrinoClient.execute(AbstractTestingTrinoClient.java:122)
2022-01-22T02:15:26.5982829Z 	at io.trino.testing.DistributedQueryRunner.execute(DistributedQueryRunner.java:505)
2022-01-22T02:15:26.5983361Z 	at io.trino.testing.QueryAssertions.assertUpdate(QueryAssertions.java:71)
2022-01-22T02:15:26.5983920Z 	at io.trino.testing.AbstractTestQueryFramework.assertUpdate(AbstractTestQueryFramework.java:235)
2022-01-22T02:15:26.5984550Z 	at io.trino.testing.AbstractTestQueryFramework.assertUpdate(AbstractTestQueryFramework.java:230)
2022-01-22T02:15:26.5985164Z 	at io.trino.testing.BaseConnectorSmokeTest.testRenameSchema(BaseConnectorSmokeTest.java:277)
2022-01-22T02:15:26.5985884Z 	at io.trino.plugin.clickhouse.BaseClickHouseConnectorSmokeTest.testRenameSchema(BaseClickHouseConnectorSmokeTest.java:40)
2022-01-22T02:15:26.5986540Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2022-01-22T02:15:26.6012885Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2022-01-22T02:15:26.6014483Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2022-01-22T02:15:26.6015061Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2022-01-22T02:15:26.6015554Z 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
2022-01-22T02:15:26.6016067Z 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
2022-01-22T02:15:26.6016511Z 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
2022-01-22T02:15:26.6020719Z 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
2022-01-22T02:15:26.6026757Z 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
2022-01-22T02:15:26.6027288Z 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
2022-01-22T02:15:26.6027847Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2022-01-22T02:15:26.6047495Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2022-01-22T02:15:26.6047937Z 	at java.base/java.lang.Thread.run(Thread.java:829)
2022-01-22T02:15:26.6048400Z 	Suppressed: java.lang.Exception: SQL: ALTER SCHEMA test_rename_schema_10ql5o2g2p RENAME TO test_rename_schema_10ql5o2g2p_renamed
2022-01-22T02:15:26.6048942Z 		at io.trino.testing.DistributedQueryRunner.execute(DistributedQueryRunner.java:508)

https://github.com/trinodb/trino/runs/4904354105

@ebyhr ebyhr merged commit 0805b93 into trinodb:master Jan 22, 2022
@ebyhr ebyhr deleted the ebi/clickhouse-disable-rename-schema-tests branch January 22, 2022 02:41
@github-actions github-actions bot added this to the 369 milestone Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants