Replace code duplicates with closeAllSuppress helper #10682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
force-pushed
the
lo/closables-helper
branch
from
e5f888d to
45bbc8a
Compare
|
CI: #10674 |
findepi
approved these changes
Jan 19, 2022
| { | ||
| requireNonNull(rootCause, "rootCause is null"); | ||
| if (closeables == null) { | ||
| return rootCause; |
There was a problem hiding this comment.
can we require closeables not to be null?
vararg call won't pass null here
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/closables-helper
branch
2 times, most recently
from
e97e06f to
6f24a01
Compare
losipiuk
commented
Jan 20, 2022
| public void testCloseAllSuppressNullClosable() | ||
| { | ||
| RuntimeException rootException = new RuntimeException("root"); | ||
| closeAllSuppress(rootException, (AutoCloseable) null); |
There was a problem hiding this comment.
@findepi If I passed just null here (without the cast) it was internally interpreted as whole closeables array and requireNonNull(closeables, "closeables is null") check trigger.
I do not think this is a big deal though. Why would someone use untyped null literal here?
There was a problem hiding this comment.
I do not think this is a big deal though. Why would someone use untyped null literal here?
agreed, that would be wrong
losipiuk
force-pushed
the
lo/closables-helper
branch
from
6f24a01 to
569e4fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.