Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix cast from date to varchar #10678

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Test and fix cast from date to varchar #10678

merged 5 commits into from
Jan 21, 2022

Conversation

kasiafi
Copy link
Member

@kasiafi kasiafi commented Jan 19, 2022 •
edited
Loading

for #552

@cla-bot cla-bot bot added the cla-signed label Jan 19, 2022
@kasiafi kasiafi mentioned this pull request Jan 19, 2022
Open
@kasiafi kasiafi force-pushed the 296CastDateTimeToVarchar branch from a8bcdf3 to cccbe55 Compare January 19, 2022 10:12
@kasiafi kasiafi requested a review from findepi January 19, 2022 12:32
@kasiafi kasiafi force-pushed the 296CastDateTimeToVarchar branch from cccbe55 to e3de11f Compare January 20, 2022 10:35
findepi
findepi approved these changes Jan 20, 2022
View reviewed changes
core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestSimplifyExpressions.java Outdated
expectedExpression);
}

private static Expression simplify(String expression)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider @Language("SQL")

@kasiafi kasiafi merged commit fca35c5 into trinodb:master Jan 21, 2022
@github-actions github-actions bot added this to the 369 milestone Jan 21, 2022
@kasiafi kasiafi mentioned this pull request Jan 21, 2022
Closed
@mosabua mosabua mentioned this pull request Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar left review comments

@findepi findepi findepi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
369
Development

Successfully merging this pull request may close these issues.
3 participants
@kasiafi @findepi @hashhar