Deny writing unsupported dates in ClickHouse #10672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
reviewed
Jan 19, 2022
| { | ||
| // Deny unsupported dates eagerly to prevent unexpected results. ClickHouse stores '1970-01-01' when the date is out of supported range. | ||
| if (value < MIN_SUPPORTED_DATE_EPOCH || value > MAX_SUPPORTED_DATE_EPOCH) { | ||
| throw new TrinoException(INVALID_ARGUMENTS, format("Epoch must be between %s and %s: %s", MIN_SUPPORTED_DATE_EPOCH, MAX_SUPPORTED_DATE_EPOCH, value)); |
There was a problem hiding this comment.
I think it makes more sense to say "Date must be between ...", since the error is referring to the input value, not the range or reference period. Per Wikipedia:
In chronology and periodization, an epoch or reference epoch is an instant in time chosen as the origin of a particular calendar era. The "epoch" serves as a reference point from which time is measured.
electrum
reviewed
Jan 19, 2022
| try (TestTable table = new TestTable(getQueryRunner()::execute, "test_unsupported_date", "(dt date)")) { | ||
| assertQueryFails( | ||
| format("INSERT INTO %s VALUES (DATE '1969-12-31')", table.getName()), | ||
| "Epoch must be between 0 and 49710: -1"); |
There was a problem hiding this comment.
It would be better to format these as dates, since that is what the user interacts with. How Clickhouse stores dates internally shouldn't matter to the Trino user.
Date must be between 1970-01-01 and 2106-02-07: 1969-12-31
electrum
approved these changes
Jan 19, 2022
ebyhr
force-pushed
the
ebi/clickhouse-deny-unsupported-dates
branch
from
97b1025 to
33b82ee
Compare
tangjiangling
added a commit
to tangjiangling/trino
that referenced
this pull request
Aug 26, 2022
The TODO was addressed in PR trinodb#10672.
ebyhr
pushed a commit
that referenced
this pull request
Aug 26, 2022
The TODO was addressed in PR #10672.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10055