Fix flaky TestExchangeClient.testAddLocation #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #10583 |
findepi
reviewed
Jan 18, 2022
| @@ -294,14 +294,14 @@ public void testAddLocation() | |||
| assertTaskIsNotFinished(buffer, task3); | |||
|
|
|||
| exchangeClient.close(); | |||
| buffer.whenTaskFinished(task3).get(10, SECONDS); | |||
| assertThat(buffer.getFinishedTasks()).containsExactlyInAnyOrder(task1, task2, task3); | |||
| assertThat(buffer.getFailedTasks().asMap()).isEmpty(); | |||
There was a problem hiding this comment.
do we still need assertEventually below?
There was a problem hiding this comment.
With the current implementation it looks like it isn't necessary
Currently the future is assigned before clientCallback.clientFinished
synchronized (HttpPageBufferClient.this) {
closed = true;
if (future == resultFuture) {
future = null;
}
lastUpdate = DateTime.now();
}
requestsCompleted.incrementAndGet();
clientCallback.clientFinished(HttpPageBufferClient.this);
However I'm not sure whether it makes sense to implicitly rely on this fact, as it may change in the future and the test may silently become flaky again.
losipiuk
approved these changes
Jan 18, 2022
Wait for the task3 to finish after closing the client
arhimondr
force-pushed
the
fix-add-locations-test
branch
from
cfaa4bd to
77bfa97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the task3 to finish after closing the client