-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClickHouse smoke tests for Altinity #10651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/clickhouse-altinity
branch
from
January 18, 2022 07:26
c24085d
to
0900888
Compare
ebyhr
force-pushed
the
ebi/clickhouse-altinity
branch
2 times, most recently
from
January 18, 2022 09:04
f2ba6f7
to
daca028
Compare
findepi
reviewed
Jan 18, 2022
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/AltinityQueryRunner.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/AltinityQueryRunner.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestingAltinityServer.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/clickhouse-altinity
branch
from
January 18, 2022 12:19
daca028
to
bb92463
Compare
ebyhr
force-pushed
the
ebi/clickhouse-altinity
branch
from
January 19, 2022 00:14
bb92463
to
ddbf7e7
Compare
@hashhar ptal |
hashhar
reviewed
Jan 19, 2022
...rino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestAltinityConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestAltinityConnectorSmokeTest.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/clickhouse-altinity
branch
from
January 19, 2022 12:03
ddbf7e7
to
5c07a26
Compare
hashhar
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % ci
Thanks for the initial review @findepi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hub.docker.com/r/altinity/clickhouse-server/tags