Clarify that username is optional #10647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this might not be correct after all. On the API level the username might be optional. Waiting for confirmation from @dain and others to see if this is a bug that will be fixed and this PR will be merged as is, or if I need to change the PR to make it consistently mentioned as optional. |
mosabua
changed the title
mosabua
changed the title
|
Got confirmation from @dain on slack .. the value is optional |
aalbu
approved these changes
Jan 18, 2022
electrum
reviewed
Jan 18, 2022
electrum
reviewed
Jan 18, 2022
mosabua
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Lukasz, Alex, and Piotr since they started this discussion. I tested with DBeaver on 365 and I get "Connection property 'user' is required". I assume this is still the case even in the API (and not just implemented in the JDBC driver). Also note the CLI just uses the operating system user if nothing is supplied. In my opinion it should be required.
Also note .. even without authentication/authorization on plain HTTP, the web UI requires a username.