Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge redundant hive cache tests classes #10645

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Merge redundant hive cache tests classes #10645

merged 3 commits into from
Jan 22, 2022

Conversation

aczajkowski
Copy link
Member

Follow up to #10385 (comment)
Merging 2 redundant test that both use query runner with hive catalog.

@cla-bot cla-bot bot added the cla-signed label Jan 17, 2022
@aczajkowski aczajkowski force-pushed the acz/merge_hive_caching_tests branch from c1eafc6 to e1f0861 Compare January 17, 2022 13:40
@aczajkowski aczajkowski force-pushed the acz/merge_hive_caching_tests branch from e1f0861 to f088b3f Compare January 17, 2022 18:57
@aczajkowski
Copy link
Member Author

@findepi got green :)

@aczajkowski aczajkowski force-pushed the acz/merge_hive_caching_tests branch from f088b3f to ebb166b Compare January 18, 2022 09:48
@aczajkowski aczajkowski requested a review from findepi January 19, 2022 19:16
@aczajkowski aczajkowski force-pushed the acz/merge_hive_caching_tests branch from ebb166b to 5bd34ff Compare January 20, 2022 11:13
@aczajkowski
Copy link
Member Author

Rebasing on top of master due to conflicts

@aczajkowski aczajkowski force-pushed the acz/merge_hive_caching_tests branch from 5bd34ff to 65a840b Compare January 20, 2022 11:29
@aczajkowski
Copy link
Member Author

@findepi @hashhar all test passed after applying all comments. One job failed in Post Action (Cleanup) 🤷‍♂️ not connected with test it self.

hashhar
hashhar approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments.

.../test/java/io/trino/plugin/hive/metastore/cache/TestCachingHiveMetastoreWithQueryRunner.java Outdated Show resolved Hide resolved
.../test/java/io/trino/plugin/hive/metastore/cache/TestCachingHiveMetastoreWithQueryRunner.java Show resolved Hide resolved
@aczajkowski aczajkowski force-pushed the acz/merge_hive_caching_tests branch from 65a840b to 63584c1 Compare January 21, 2022 17:31
hashhar
hashhar approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. will merge once CI is done.

@aczajkowski
Copy link
Member Author

@hashhar got green :)

@hashhar hashhar merged commit cd03dda into trinodb:master Jan 22, 2022
@github-actions github-actions bot added this to the 369 milestone Jan 22, 2022
@mosabua mosabua mentioned this pull request Jan 24, 2022
Merged
@aczajkowski aczajkowski deleted the acz/merge_hive_caching_tests branch February 7, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@findepi findepi Awaiting requested review from findepi

Assignees

@hashhar hashhar

Labels
cla-signed
Milestone
369
Development

Successfully merging this pull request may close these issues.
3 participants
@aczajkowski @findepi @hashhar