Migrate code away from anonymous class using initializers #10633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/migrate-code-away-from-anonymous-class-using-initializers-56c2d4
branch
from
746e099 to
b5eb717
Compare
|
Does either ErrorProne or Modernizr provide some way to enforce this? |
kokosing
approved these changes
Jan 15, 2022
I can try to imagine legitimate use-case for an initializer in an anonymous class. |
Also adds necessary dependencies to make sure such problems are detected in the module.
While it's possible to create a pre-populated collection using `new
CollectionClass() { { ... add elements ... } }`, it is not the idiomatic
way to do it.
findepi
commented
Jan 15, 2022
| checkRequest(server.takeRequest(5, TimeUnit.SECONDS), new HashMap<>() {{ | ||
| put("Authorization", "Trust Me!"); | ||
| put("Cache-Control", "no-cache"); | ||
| }}, queryCompleteEvent); |
There was a problem hiding this comment.
i lost queryCompleteEvent.
i don't understand how CI figured this out, as this test method is not @Test annotated (#10635), yet it failed (https://github.com/trinodb/trino/runs/4826429554?check_suite_focus=true)
findepi
force-pushed
the
findepi/migrate-code-away-from-anonymous-class-using-initializers-56c2d4
branch
from
b5eb717 to
a0cdaa0
Compare
findepi
deleted the
findepi/migrate-code-away-from-anonymous-class-using-initializers-56c2d4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's possible to create a pre-populated collection using
new CollectionClass() { { ... add elements ... } }, it is not the idiomaticway to do it.