Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JDBC Driver.getPropertyInfo() and validate allowed properties #10625

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Fix JDBC Driver.getPropertyInfo() and validate allowed properties #10625

merged 2 commits into from
Mar 15, 2022

Conversation

electrum
Copy link
Member

@electrum electrum commented Jan 14, 2022 •
edited
Loading

Fixes #10624

@cla-bot cla-bot bot added the cla-signed label Jan 14, 2022
@findepi findepi added the jdbc Relates to Trino JDBC driver label Jan 15, 2022
@electrum electrum requested a review from kokosing January 28, 2022 18:48
@electrum electrum force-pushed the jdbc-propertyinfo branch from 4a0a39e to a29f2c2 Compare March 4, 2022 19:03
@mosabua
Copy link
Member

mosabua commented Mar 9, 2022

Can we get this merged before the 372 release maybe @martint and @electrum ?

@electrum electrum force-pushed the jdbc-propertyinfo branch from a29f2c2 to 611bfb3 Compare March 14, 2022 21:27
@electrum electrum force-pushed the jdbc-propertyinfo branch from 611bfb3 to 01f0835 Compare March 15, 2022 05:37
@electrum electrum merged commit 48e0bfa into trinodb:master Mar 15, 2022
@electrum electrum deleted the jdbc-propertyinfo branch March 15, 2022 14:03
@mosabua
Copy link
Member

mosabua commented Mar 15, 2022

Awesome. I will let the DBVisualizer team know..

@mosabua mosabua mentioned this pull request Mar 15, 2022
Merged
@github-actions github-actions bot added this to the 374 milestone Mar 15, 2022
@v-jizhang v-jizhang mentioned this pull request Mar 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing kokosing approved these changes

Assignees
No one assigned
Labels
cla-signed jdbc Relates to Trino JDBC driver
Milestone
374
Development

Successfully merging this pull request may close these issues.

JDBC driver does not return list of properties
4 participants
@electrum @mosabua @kokosing @findepi