Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix materialized views to allow duplicated source tables without breaking the metadata schema #10570

Conversation

berndlunghamer
Copy link
Contributor

@berndlunghamer berndlunghamer commented Jan 12, 2022

fix #10229, remove duplicates from materialized view source tables when saving metdata

Fixes #10229

@cla-bot
Copy link

cla-bot bot commented Jan 12, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@sopel39
Copy link
Member

sopel39 commented Jan 13, 2022

please rebase and squash commits

@berndlunghamer berndlunghamer force-pushed the bugfix/iceberg-matview-allow-same-source-table branch from 9cacbf4 to 6caaea3 Compare January 13, 2022 11:39
@cla-bot
Copy link

cla-bot bot commented Jan 13, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@berndlunghamer berndlunghamer force-pushed the bugfix/iceberg-matview-allow-same-source-table branch from 6caaea3 to 87d9c8f Compare January 13, 2022 11:54
@cla-bot
Copy link

cla-bot bot commented Jan 13, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@sopel39
Copy link
Member

sopel39 commented Jan 13, 2022

@berndlunghamer could you sign CLA?

@berndlunghamer
Copy link
Contributor Author

@berndlunghamer could you sign CLA?

yes, i have sent it to [email protected] from two different email addresses but have not heard back and github handles have not been updated to the cla repo.

@sopel39
Copy link
Member

sopel39 commented Jan 14, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 14, 2022
@cla-bot
Copy link

cla-bot bot commented Jan 14, 2022

The cla-bot has been summoned, and re-checked this pull request!

@sopel39 sopel39 merged commit 670dfd5 into trinodb:master Jan 14, 2022
@sopel39
Copy link
Member

sopel39 commented Jan 14, 2022

merged, thanks!

@sopel39 sopel39 mentioned this pull request Jan 14, 2022
@github-actions github-actions bot added this to the 369 milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[MATERIALIZED VIEW]: java.lang.IllegalArgumentException: Duplicate key [tpcds1t.b] found
3 participants