Fix query failure when accessing numeric types in BigQuery #10565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/bigquery-fix-numeric
branch
from
329b3af to
596a292
Compare
ebyhr
force-pushed
the
ebi/bigquery-fix-numeric
branch
from
596a292 to
ebd83b9
Compare
wendigo
approved these changes
Jan 12, 2022
losipiuk
reviewed
Jan 12, 2022
| @@ -190,7 +191,7 @@ else if (type.equals(TIME_MICROS)) { | |||
| else if (javaType == double.class) { | |||
| type.writeDouble(output, ((Number) value).doubleValue()); | |||
| } | |||
| else if (javaType == Slice.class) { | |||
| else if (javaType == Slice.class || type.getJavaType() == Int128.class) { | |||
There was a problem hiding this comment.
writeSlice method name is misleading.
losipiuk
approved these changes
Jan 12, 2022
|
Can you add a regression test for this? |
|
@ksobolew The tests already exist in testBigNumericMapping and testNumericMapping in TestBigQueryTypeMapping. |
...and they must be run manually, unfortunately. Thanks! |
hashhar
approved these changes
Jan 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10564
Verified all tests locally.