Set keep_alive_timeout as 10 seconds in ClickHouse testing server #10542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Jan 11, 2022
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0"?> | |||
| <yandex> | |||
| <keep_alive_timeout>10</keep_alive_timeout> | |||
There was a problem hiding this comment.
Why? add code comment here & in cmt message too.
There was a problem hiding this comment.
The purpose is fixing flaky server as ClickHouse/clickhouse-java#717.
| @@ -33,6 +34,7 @@ public TestingClickHouseServer() | |||
| { | |||
| // Use 2nd stable version | |||
| dockerContainer = (ClickHouseContainer) new ClickHouseContainer(CLICKHOUSE_IMAGE) | |||
| .withCopyFileToContainer(forClasspathResource("config.xml"), "/etc/clickhouse-server/config.d/config.xml") | |||
There was a problem hiding this comment.
Is there /etc/clickhouse-server/config.d/config.xml in the image?
or we're creating a new file? then, can we give it a more specific name?
There was a problem hiding this comment.
It's a new file. I renamed to custom.yml.
For avoiding below failure during copy of TPCH tables. ClickHouse exception, code: 1002, host: localhost, port: <port>; localhost:<port> failed to respond
ebyhr
force-pushed
the
ebi/clickhouse-keep_alive_timeout
branch
from
f958e26 to
7e7c2c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9300
300 stress tests succeeded.