Capture column level dependencies for CTEs and sub-queries #10319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
praveen/lineage/bug_fix_1
branch
2 times, most recently
from
bf80c53 to
f816848
Compare
ksobolew
reviewed
Dec 16, 2021
Comment on lines
2044
to
2046
| descriptor.getAllFields().stream(), | ||
| relationType.getAllFields().stream() | ||
| .filter(field -> canProcessHiddenColumn || !field.isHidden()), |
There was a problem hiding this comment.
How can we be sure that these two streams are in lock-step?
There was a problem hiding this comment.
Have added additional checks.
martint
reviewed
Dec 16, 2021
| @@ -2035,6 +2039,13 @@ protected Scope visitAliasedRelation(AliasedRelation relation, Optional<Scope> s | |||
|
|
|||
| RelationType descriptor = relationType.withAlias(relation.getAlias().getValue(), aliases); | |||
|
|
|||
| boolean canProcessHiddenColumn = aliases == null; | |||
There was a problem hiding this comment.
This is not ideal. It's relying on an internal non-obvious detail of withAlias.
martint
approved these changes
Dec 17, 2021
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
Previously they weren't captured if some transformation is applied on columns referenced from CTEs or Aliased relation.
Praveen2112
force-pushed
the
praveen/lineage/bug_fix_1
branch
from
ce7c9c9 to
3444d97
Compare
kokosing
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they weren't captured if some transformation is applied on
columns referenced from CTEs or Aliased relation.