Test and fix casts from exact numeric types to varchar #10170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiafi
changed the title
findepi
approved these changes
Dec 3, 2021
core/trino-main/src/test/java/io/trino/type/TestIntegerOperators.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/TestExpressionInterpreter.java
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/type/TestDecimalCasts.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/type/TestDecimalCasts.java
Outdated
Show resolved
Hide resolved
kasiafi
force-pushed
the
291CastToVarcharContinued
branch
from
a10435c to
e951437
Compare
This change applies to the following types: integer, smallint, tinyint, decimal (both short and long). The binigt type was handled in another PR.
Fail if the resulting string does not fit in the bounded length of the varchar type.
Fail if the resulting string does not fit in the bounded length of the varchar type.
Fail if the resulting string does not fit in the bounded length of the varchar type.
Fail if the resulting string does not fit in the bounded length of the varchar type. Applies both to short and long decimal types.
kasiafi
force-pushed
the
291CastToVarcharContinued
branch
from
e951437 to
850674e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to: integer, smallint, tinyint, decimal.
Bigint was handlen in another PR
For #552