Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 365 release notes #10145

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Add 365 release notes #10145

merged 1 commit into from
Dec 4, 2021

Conversation

martint
Copy link
Member

@martint martint commented Dec 1, 2021

Closes #9826

@cla-bot cla-bot bot added the cla-signed label Dec 1, 2021
@martint martint requested a review from a team December 1, 2021 22:47
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
Copy link
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't checked if all release notes are added

docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
@martint martint force-pushed the relnotes branch 2 times, most recently from 9956687 to a9a8ede Compare December 3, 2021 20:12
docs/src/main/sphinx/release/release-365.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
* Account memory used for tracking information about deleted rows when reading from Hive ACID tables. ({issue}`9914`, {issue}`10070`)
* Fix `REVOKE GRANT OPTION` to revoke only the granting instead of revoking entire privilege. ({issue}`10094`)
* Fix bug that skips writing bloom filters for ORC files. ({issue}`9792`)
* Fix bug where incorrect rows were deleted when deleting from a transactional table that has original files (before the first major compaction). ({issue}`10095`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds serious. Should we put it to the top and some emphasise it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally list changes in order of:

  • new features
  • performance improvements
  • bug fixes

Not sure where we would put this to make it more prominent.

* Fix bug where incorrect rows were deleted when deleting from a transactional table that has original files (before the first major compaction). ({issue}`10095`)
* Fix delete and update failure when changing a table after a major compaction. ({issue}`10120`)
* Fix incorrect results when decoding decimal values in Parquet reader. ({issue}`9971`)
* Fix ``hive.dynamic-filtering.wait-timeout`` not having any effect. ({issue}`10106`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it? Does it mean that previously that flag was not effective? Can we improve wording?

Fix .... to be effective, previously flag was ignored.
?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@martint martint Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand it, it wasn't being ignored, but there was a bug in the implementation.

@martint martint force-pushed the relnotes branch 2 times, most recently from f047840 to d0cca7f Compare December 3, 2021 21:36
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-365.md Outdated Show resolved Hide resolved
@martint
Copy link
Member Author

martint commented Dec 3, 2021

@electrum, updated

@martint martint merged commit f7835e3 into trinodb:master Dec 4, 2021
@github-actions github-actions bot added this to the 365 milestone Dec 4, 2021
@ebyhr ebyhr mentioned this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Release notes for 365
8 participants