Compat issue on COLLECTION_DELIM in Hive 3.x

[7c00]

HIVE-16922 fixed the typo of org.apache.hadoop.hive.serde.serdeConstants#COLLECTION_DELIM, but also introduced a breaking change.

#1321 fixed this compatibility issue for RC files, while leaving TEXT files out.

We walk around it by changing the io.prestosql.plugin.hive.HiveUtil#getDeserializer

public static Deserializer getDeserializer(Configuration configuration, Properties schema)
    {
        String name = getDeserializerClassName(schema);

        // fix compat issue: colelction.delim in Hive 2.x, but collection.delim in Hive 3.x
        // see also https://issues.apache.org/jira/browse/HIVE-16922
        if (name.equals("org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe")) {
            if (schema.containsKey("colelction.delim") && !schema.containsKey(COLLECTION_DELIM)) {
                schema.put(COLLECTION_DELIM, schema.getProperty("colelction.delim"));
            }
        }

        Deserializer deserializer = createDeserializer(getDeserializerClass(name));
        initializeDeserializer(configuration, deserializer, schema);
        return deserializer;
    }

[Anurag870]

Created PR #1733

[JustanotherN8]

You guys are doing a great job

[findepi]

Solved by #1733