Remove redundant Guice-like annotation

`@ForBigQuery` was meaningless, because it lacked runtime retention. Guice could not obey the annotation since it didn't see it.
trinodb · May 14, 2024 · f9a6fd9 · f9a6fd9
1 parent 9bc94e6
commit f9a6fd9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConnectorModule.java b/plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConnectorModule.java
@@ -30,7 +30,6 @@
 import io.trino.spi.NodeManager;
 import io.trino.spi.function.table.ConnectorTableFunction;
 
-import java.lang.annotation.Target;
 import java.lang.management.ManagementFactory;
 import java.util.Set;
 import java.util.regex.Matcher;
@@ -43,10 +42,6 @@
 import static io.airlift.configuration.ConditionalModule.conditionalModule;
 import static io.airlift.configuration.ConfigBinder.configBinder;
 import static io.trino.plugin.bigquery.BigQueryConfig.ARROW_SERIALIZATION_ENABLED;
-import static java.lang.annotation.ElementType.CONSTRUCTOR;
-import static java.lang.annotation.ElementType.FIELD;
-import static java.lang.annotation.ElementType.METHOD;
-import static java.lang.annotation.ElementType.PARAMETER;
 import static java.util.concurrent.Executors.newFixedThreadPool;
 import static java.util.stream.Collectors.toSet;
 
@@ -122,7 +117,6 @@ public static BigQueryLabelFactory labelFactory(BigQueryConfig config)
         }
 
         @Provides
-        @ForBigQuery
         public ListeningExecutorService provideListeningExecutor(BigQueryConfig config)
         {
             return listeningDecorator(newFixedThreadPool(config.getMetadataParallelism(), daemonThreadsNamed("big-query-%s"))); // limit parallelism
@@ -186,9 +180,4 @@ protected void setup(Binder binder)
             }
         }
     }
-
-    @Target({PARAMETER, FIELD, METHOD, CONSTRUCTOR})
-    public @interface ForBigQuery
-    {
-    }
 }
diff --git a/...trino-bigquery/src/main/java/io/trino/plugin/bigquery/DefaultBigQueryMetadataFactory.java b/...trino-bigquery/src/main/java/io/trino/plugin/bigquery/DefaultBigQueryMetadataFactory.java
@@ -16,7 +16,6 @@
 import com.google.common.util.concurrent.ListeningExecutorService;
 import com.google.inject.Inject;
 
-import static io.trino.plugin.bigquery.BigQueryConnectorModule.ForBigQuery;
 import static java.util.Objects.requireNonNull;
 
 public class DefaultBigQueryMetadataFactory
@@ -31,7 +30,7 @@ public class DefaultBigQueryMetadataFactory
     public DefaultBigQueryMetadataFactory(
             BigQueryClientFactory bigQueryClient,
             BigQueryTypeManager typeManager,
-            @ForBigQuery ListeningExecutorService executorService,
+            ListeningExecutorService executorService,
             BigQueryConfig config)
     {
         this.bigQueryClient = requireNonNull(bigQueryClient, "bigQueryClient is null");