Populate TestTable with multi-row INSERT

Use single INSERT instead of multiple single-row inserts. Should be faster, especially e.g. for Trino.
trinodb · Aug 30, 2023 · f12bf10 · f12bf10
1 parent f9483bb
commit f12bf10
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 4 deletions.
diff --git a/plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/TestOracleConnectorTest.java b/plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/TestOracleConnectorTest.java
@@ -81,6 +81,18 @@ private String getLongInClause(int start, int length)
     @Override
     protected SqlExecutor onRemoteDatabase()
     {
-        return oracleServer::execute;
+        return new SqlExecutor() {
+            @Override
+            public boolean supportsMultiRowInsert()
+            {
+                return false;
+            }
+
+            @Override
+            public void execute(String sql)
+            {
+                oracleServer.execute(sql);
+            }
+        };
     }
 }
diff --git a/plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/PhoenixSqlExecutor.java b/plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/PhoenixSqlExecutor.java
@@ -41,6 +41,12 @@ public PhoenixSqlExecutor(String jdbcUrl, Properties jdbcProperties)
         this.jdbcProperties.putAll(requireNonNull(jdbcProperties, "jdbcProperties is null"));
     }
 
+    @Override
+    public boolean supportsMultiRowInsert()
+    {
+        return false;
+    }
+
     @Override
     public void execute(String sql)
     {

diff --git a/testing/trino-testing/src/main/java/io/trino/testing/sql/SqlExecutor.java b/testing/trino-testing/src/main/java/io/trino/testing/sql/SqlExecutor.java
@@ -15,5 +15,10 @@
 
 public interface SqlExecutor
 {
+    default boolean supportsMultiRowInsert()
+    {
+        return true;
+    }
+
     void execute(String sql);
 }
diff --git a/testing/trino-testing/src/main/java/io/trino/testing/sql/TestTable.java b/testing/trino-testing/src/main/java/io/trino/testing/sql/TestTable.java
@@ -24,6 +24,7 @@
 import static java.lang.String.format;
 import static java.lang.String.join;
 import static java.util.Objects.requireNonNull;
+import static java.util.stream.Collectors.joining;
 
 public class TestTable
         implements TemporaryRelation
@@ -49,9 +50,17 @@ protected void createAndInsert(List<String> rowsToInsert)
     {
         sqlExecutor.execute(format("CREATE TABLE %s %s", name, tableDefinition));
         try {
-            for (String row : rowsToInsert) {
-                // some databases do not support multi value insert statement
-                sqlExecutor.execute(format("INSERT INTO %s VALUES (%s)", name, row));
+            if (!rowsToInsert.isEmpty()) {
+                if (sqlExecutor.supportsMultiRowInsert()) {
+                    sqlExecutor.execute(format("INSERT INTO %s VALUES %s", name, rowsToInsert.stream()
+                            .map("(%s)"::formatted)
+                            .collect(joining(", "))));
+                }
+                else {
+                    for (String row : rowsToInsert) {
+                        sqlExecutor.execute(format("INSERT INTO %s VALUES (%s)", name, row));
+                    }
+                }
             }
         }
         catch (Exception e) {