Produce a more actionable error on wrong JDBC URL

trinodb · Dec 7, 2023 · dc880e9 · dc880e9
1 parent a0f8178
commit dc880e9
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/TracingDataSource.java b/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/TracingDataSource.java
@@ -25,6 +25,7 @@
 import java.util.Properties;
 import java.util.logging.Logger;
 
+import static com.google.common.base.Preconditions.checkState;
 import static java.util.Objects.requireNonNull;
 
 public class TracingDataSource
@@ -70,7 +71,9 @@ public JdbcDataSource(Driver driver, String connectionUrl, Properties properties
         public Connection getConnection()
                 throws SQLException
         {
-            return driver.connect(connectionUrl, properties);
+            Connection connection = driver.connect(connectionUrl, properties);
+            checkState(connection != null, "Driver returned null connection, make sure the connection URL '%s' is valid for the driver %s", connectionUrl, driver);
+            return connection;
         }
 
         @Override