Skip to content

Commit

Permalink
Move sendPlan out of critical section
Browse files Browse the repository at this point in the history
sendPlan doesn't have to be in critical
section since it's atomic and sending of
plan is idempotent.
  • Loading branch information
sopel39 committed Sep 2, 2022
1 parent 26dc73e commit d9f2689
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -920,10 +920,10 @@ public void success(TaskInfo value)
sentDynamicFiltersVersion.set(currentRequestDynamicFiltersVersion);
// Remove dynamic filters which were successfully sent to free up memory
outboundDynamicFiltersCollector.acknowledge(currentRequestDynamicFiltersVersion);
sendPlan.set(value.isNeedsPlan());
long currentRequestStartNanos;
synchronized (HttpRemoteTask.this) {
currentRequest = null;
sendPlan.set(value.isNeedsPlan());
currentRequestStartNanos = HttpRemoteTask.this.currentRequestStartNanos;
}
updateStats(currentRequestStartNanos);
Expand Down

0 comments on commit d9f2689

Please sign in to comment.