Remove ConfigHdp3 since it's same as the default config

.github/workflows/ci.yml

@@ -902,14 +902,15 @@ jobs:
           cat <<EOF > .github/test-pt-matrix.yaml
           config:
             - default
-            - hdp3
-            # TODO: config-apache-hive3
           suite:
             - suite-1
             - suite-2
             - suite-3
             # suite-4 does not exist
             - suite-5
+            - suite-6-non-generic
+            - suite-7-non-generic
+            - suite-8-non-generic
             - suite-azure
             - suite-delta-lake-databricks91
             - suite-delta-lake-databricks104
@@ -920,53 +921,45 @@ jobs:
             - suite-clients
             - suite-functions
             - suite-tpch
+            - suite-tpcds
             - suite-storage-formats-detailed
+            - suite-parquet
+            - suite-oauth2
+            - suite-ldap
+            - suite-compatibility
+            - suite-all-connectors-smoke
+            - suite-delta-lake-oss
+            - suite-kafka
+            - suite-cassandra
+            - suite-clickhouse
+            - suite-mysql
+            - suite-iceberg
+            - suite-hudi
+            - suite-ignite
           exclude:
-            - config: default
-              ignore exclusion if: >-
-                ${{ github.event_name != 'pull_request'
-                 || github.event.pull_request.head.repo.full_name == github.repository
-                 || contains(github.event.pull_request.labels.*.name, 'tests:all')
-                 || contains(github.event.pull_request.labels.*.name, 'tests:hive')
-                 }}
-
-            - suite: suite-azure
-              config: default
             - suite: suite-azure
               ignore exclusion if: >-
                 ${{ env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' ||
                     secrets.AZURE_ABFS_CONTAINER != '' ||
                     secrets.AZURE_ABFS_ACCOUNT != '' ||
                     secrets.AZURE_ABFS_ACCESSKEY != '' }}
 
-            - suite: suite-gcs
-              config: default
             - suite: suite-gcs
               ignore exclusion if: >-
                 ${{ env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || secrets.GCP_CREDENTIALS_KEY != '' }}
 
-            - suite: suite-delta-lake-databricks91
-              config: hdp3
             - suite: suite-delta-lake-databricks91
               ignore exclusion if: >-
                 ${{ env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || secrets.DATABRICKS_TOKEN != '' }}
-            - suite: suite-delta-lake-databricks104
-              config: hdp3
             - suite: suite-delta-lake-databricks104
               ignore exclusion if: >-
                 ${{ env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || secrets.DATABRICKS_TOKEN != '' }}
-            - suite: suite-delta-lake-databricks113
-              config: hdp3
             - suite: suite-delta-lake-databricks113
               ignore exclusion if: >-
                 ${{ env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || secrets.DATABRICKS_TOKEN != '' }}
-            - suite: suite-delta-lake-databricks122
-              config: hdp3
             - suite: suite-delta-lake-databricks122
               ignore exclusion if: >-
                 ${{ env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || secrets.DATABRICKS_TOKEN != '' }}
-            - suite: suite-delta-lake-databricks133
-              config: hdp3
             - suite: suite-delta-lake-databricks133
               ignore exclusion if: >-
                 ${{ env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || secrets.DATABRICKS_TOKEN != '' }}
@@ -983,60 +976,9 @@ jobs:
             #   value of the property, and the exclusion will apply normally.
             - "false"
           include:
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-6-non-generic
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-7-non-generic
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-8-non-generic
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-tpcds
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-parquet
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-oauth2
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-ldap
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-compatibility
             # this suite is designed specifically for apache-hive3. TODO remove the suite once we can run all regular tests on apache-hive3.
             - config: apache-hive3
               suite: suite-hms-only
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-all-connectors-smoke
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-delta-lake-oss
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-kafka
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-cassandra
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-clickhouse
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-mysql
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-iceberg
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-hudi
-            # this suite is not meant to be run with different configs
-            - config: default
-              suite: suite-ignite
           EOF
       - name: Build PT matrix (all)
         if: |

testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Hadoop.java

@@ -81,6 +81,8 @@ public static DockerContainer createHadoopContainer(DockerFiles dockerFiles, Por
                 .withCopyFileToContainer(forHostPath(dockerFiles.getDockerFilesHostPath("health-checks/hadoop-health-check.sh")), CONTAINER_HEALTH_D + "hadoop-health-check.sh")
                 .withCopyFileToContainer(forHostPath(dockerFiles.getDockerFilesHostPath("common/hadoop/hadoop-run.sh")), "/usr/local/hadoop-run.sh")
                 .withCopyFileToContainer(forHostPath(dockerFiles.getDockerFilesHostPath("common/hadoop/apply-config-overrides.sh")), CONTAINER_HADOOP_INIT_D + "00-apply-config-overrides.sh")
+                // When hive performs implicit coercion to/from timestamp for ORC files, it depends on timezone of the HiveServer
+                .withEnv("TZ", "UTC")
                 .withCommand("/usr/local/hadoop-run.sh")
                 .withExposedLogPaths("/var/log/hadoop-yarn", "/var/log/hadoop-hdfs", "/var/log/hive", "/var/log/container-health.log")
                 .withStartupCheckStrategy(new IsRunningStartupCheckStrategy())

testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodeGcs.java

@@ -87,7 +87,6 @@ public void extendEnvironment(Environment.Builder builder)
 
         String containerGcpCredentialsFile = CONTAINER_TRINO_ETC + "gcp-credentials.json";
         builder.configureContainer(HADOOP, container -> {
-            container.setDockerImageName("ghcr.io/trinodb/testing/hdp3.1-hive:" + hadoopImageVersion);
             container.withCopyFileToContainer(
                     forHostPath(getCoreSiteOverrideXml(containerGcpCredentialsFile)),
                     "/docker/presto-product-tests/conf/environment/multinode-gcs/core-site-overrides.xml");

testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeHiveHudiRedirections.java

@@ -75,9 +75,6 @@ public EnvSinglenodeHiveHudiRedirections(
     @Override
     public void extendEnvironment(Environment.Builder builder)
     {
-        // Using hdp3.1 so we are using Hive metastore with version close to versions of hive-*.jars Spark uses
-        builder.configureContainer(HADOOP, container -> container.setDockerImageName("ghcr.io/trinodb/testing/hdp3.1-hive:" + hadoopImagesVersion));
-
         builder.addConnector("hive", forHostPath(configDir.getPath("hive.properties")));
         builder.addConnector("hudi", forHostPath(configDir.getPath("hudi.properties")));
 

testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeHudi.java

@@ -80,8 +80,6 @@ public EnvSinglenodeHudi(
     @Override
     public void extendEnvironment(Environment.Builder builder)
     {
-        // Using hdp3.1 so we are using Hive metastore with version close to versions of hive-*.jars Spark uses
-        builder.configureContainer(HADOOP, container -> container.setDockerImageName("ghcr.io/trinodb/testing/hdp3.1-hive:" + hadoopImagesVersion));
         builder.addConnector(
                 "hive",
                 forHostPath(configDir.getPath("hive.properties")),

testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeSparkHiveNoStatsFallback.java

@@ -55,7 +55,6 @@ public EnvSinglenodeSparkHiveNoStatsFallback(Standard standard, Hadoop hadoop, D
     @Override
     public void extendEnvironment(Environment.Builder builder)
     {
-        builder.configureContainer(HADOOP, container -> container.setDockerImageName("ghcr.io/trinodb/testing/hdp3.1-hive:" + hadoopImagesVersion));
         builder.addConnector("hive", forHostPath(configDir.getPath("hive.properties")));
         builder.addContainer(createSpark()).containerDependsOn("spark", HADOOP);
     }

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/common/hadoop/hive.properties

@@ -14,3 +14,5 @@ hive.fs.cache.max-size=10
 hive.max-partitions-per-scan=100
 hive.max-partitions-for-eager-load=100
 hive.hive-views.enabled=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/common/hadoop/hive_timestamp_nanos.properties

@@ -5,3 +5,5 @@ hive.allow-drop-table=true
 hive.metastore-cache-ttl=0s
 hive.hive-views.enabled=true
 hive.timestamp-precision=NANOSECONDS
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/common/hadoop/hive_with_external_writes.properties

@@ -15,3 +15,5 @@ hive.max-partitions-per-scan=100
 hive.max-partitions-for-eager-load=100
 hive.hive-views.enabled=true
 hive.non-managed-table-writes-enabled=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/common/hadoop/hive_with_run_view_as_invoker.properties

@@ -6,3 +6,5 @@ hive.fs.cache.max-size=10
 hive.hive-views.enabled=true
 hive.hive-views.run-as-invoker=true
 hive.security=sql-standard
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode-azure/hive.properties

@@ -11,3 +11,5 @@ hive.allow-comment-table=true
 hive.allow-drop-table=true
 hive.allow-rename-table=true
 hive.translate-hive-views=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode-cached/hive-coordinator.properties

@@ -3,3 +3,5 @@ hive.config.resources=/docker/presto-product-tests/conf/presto/etc/hive-default-
 hive.metastore.uri=thrift://hadoop-master:9083
 hive.allow-drop-table=true
 hive.cache.enabled=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode-cached/hive-worker.properties

@@ -4,3 +4,5 @@ hive.metastore.uri=thrift://hadoop-master:9083
 hive.allow-drop-table=true
 hive.cache.enabled=true
 hive.cache.location=/tmp/cache
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode-gcs/hive.properties

@@ -9,3 +9,5 @@ hive.allow-rename-column=true
 hive.allow-comment-table=true
 hive.allow-drop-table=true
 hive.allow-rename-table=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode-minio-data-lake/hive.properties

@@ -6,3 +6,5 @@ hive.s3.endpoint=http://minio:9080/
 hive.s3.path-style-access=true
 hive.s3.ssl.enabled=false
 hive.allow-drop-table=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode-tls-kerberos/hive.properties

@@ -9,6 +9,8 @@ hive.metastore-cache-ttl=0s
 hive.allow-add-column=true
 hive.allow-drop-column=true
 hive.allow-rename-column=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC
 
 hive.metastore.authentication.type=KERBEROS
 hive.metastore.service.principal=hive/[email protected]

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-compatibility/hive-hadoop2.properties

@@ -1,2 +1,4 @@
 connector.name=hive-hadoop2
 hive.metastore.uri=thrift://hadoop-master:9083
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-compatibility/hive.properties

@@ -1,2 +1,4 @@
 connector.name=hive
 hive.metastore.uri=thrift://hadoop-master:9083
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-delta-lake-databricks/hive.properties

@@ -11,3 +11,5 @@ hive.allow-comment-table=true
 hive.allow-comment-column=true
 hive.allow-rename-table=true
 hive.delta-lake-catalog-name=delta
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-delta-lake-oss/hive.properties

@@ -13,3 +13,5 @@ hive.allow-comment-table=true
 hive.allow-comment-column=true
 hive.allow-rename-table=true
 hive.delta-lake-catalog-name=delta
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-hdfs-impersonation/hive.properties

@@ -15,3 +15,5 @@ hive.fs.cache.max-size=10
 hive.max-partitions-per-scan=100
 hive.max-partitions-for-eager-load=100
 hive.non-managed-table-writes-enabled=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-hive-hudi-redirections/hive.properties

@@ -9,3 +9,5 @@ hive.allow-drop-table=true
 hive.allow-rename-table=true
 hive.hudi-catalog-name=hudi
 hive.hive-views.enabled=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-hive-iceberg-redirections/hive.properties

@@ -9,3 +9,5 @@ hive.allow-drop-table=true
 hive.allow-rename-table=true
 hive.iceberg-catalog-name=iceberg
 hive.hive-views.enabled=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-hive-impersonation/hive.properties

@@ -17,3 +17,5 @@ hive.fs.cache.max-size=10
 hive.max-partitions-per-scan=100
 hive.max-partitions-for-eager-load=100
 hive.non-managed-table-writes-enabled=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-hudi/hive.properties

@@ -2,3 +2,5 @@ connector.name=hive
 hive.metastore.uri=thrift://hadoop-master:9083
 hive.config.resources=/docker/presto-product-tests/conf/presto/etc/hive-default-fs-site.xml
 hive.allow-drop-table=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-kerberos-hdfs-impersonation-cross-realm/hive.properties

@@ -15,6 +15,8 @@ hive.metastore-cache-ttl=0s
 hive.allow-add-column=true
 hive.allow-drop-column=true
 hive.allow-rename-column=true
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC
 
 hive.metastore.authentication.type=KERBEROS
 hive.metastore.service.principal=hive/[email protected]

testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/singlenode-kerberos-hdfs-impersonation-with-data-protection/hive.properties

@@ -2,6 +2,8 @@ connector.name=hive
 hive.metastore.uri=thrift://hadoop-master:9083
 hive.config.resources=/docker/presto-product-tests/conf/presto/etc/hive-default-fs-site.xml,/docker/presto-product-tests/conf/presto/etc/hive-data-protection-site.xml
 hive.metastore-cache-ttl=0s
+hive.parquet.time-zone=UTC
+hive.rcfile.time-zone=UTC
 
 hive.metastore.authentication.type=KERBEROS
 hive.metastore.service.principal=hive/[email protected]