Minor cleanup in connectors

- inline field - remove obvious comments - limit access to field - remove explicit default constructor
trinodb · Jul 5, 2021 · cbea02b · cbea02b
1 parent 5cacd61
commit cbea02b
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 34 deletions.
diff --git a/plugin/trino-kinesis/src/main/java/io/trino/plugin/kinesis/KinesisConnectorFactory.java b/plugin/trino-kinesis/src/main/java/io/trino/plugin/kinesis/KinesisConnectorFactory.java
@@ -32,17 +32,9 @@
 import static com.google.common.base.Throwables.throwIfUnchecked;
 import static java.util.Objects.requireNonNull;
 
-/**
- * This factory class creates the KinesisConnector during server start and binds all the dependency
- * by calling create() method.
- */
 public class KinesisConnectorFactory
         implements ConnectorFactory
 {
-    public KinesisConnectorFactory()
-    {
-    }
-
     @Override
     public String getName()
     {
@@ -78,8 +70,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
                     .setRequiredConfigurationProperties(config)
                     .initialize();
 
-            KinesisConnector connector = injector.getInstance(KinesisConnector.class);
-            return connector;
+            return injector.getInstance(KinesisConnector.class);
         }
         catch (Exception e) {
             throwIfUnchecked(e);

diff --git a/...no-kinesis/src/test/java/io/trino/plugin/kinesis/TestKinesisTableDescriptionSupplier.java b/...no-kinesis/src/test/java/io/trino/plugin/kinesis/TestKinesisTableDescriptionSupplier.java
@@ -33,12 +33,8 @@
 import static org.testng.Assert.assertNotNull;
 import static org.testng.Assert.assertTrue;
 
-/**
- * Unit test for the TableDescriptionSupplier and related classes
- */
 public class TestKinesisTableDescriptionSupplier
 {
-    private KinesisPlugin kinesisPlugin;
     private KinesisConnector connector;
 
     @BeforeClass
@@ -57,7 +53,7 @@ public void start()
         mockClient.createStream("sampleTable", 2);
         KinesisConnectorFactory kinesisConnectorFactory = new TestingKinesisConnectorFactory(kinesisTestClientManager);
 
-        kinesisPlugin = new KinesisPlugin(kinesisConnectorFactory);
+        KinesisPlugin kinesisPlugin = new KinesisPlugin(kinesisConnectorFactory);
         connector = TestUtils.createConnector(kinesisPlugin, properties, true);
     }
 

diff --git a/...n/trino-kinesis/src/test/java/io/trino/plugin/kinesis/TestingKinesisConnectorFactory.java b/...n/trino-kinesis/src/test/java/io/trino/plugin/kinesis/TestingKinesisConnectorFactory.java
@@ -33,7 +33,7 @@
 public class TestingKinesisConnectorFactory
         extends KinesisConnectorFactory
 {
-    KinesisClientProvider kinesisClientProvider;
+    private KinesisClientProvider kinesisClientProvider;
 
     public TestingKinesisConnectorFactory(KinesisClientProvider kinesisClientProvider)
     {

diff --git a/plugin/trino-kinesis/src/test/java/io/trino/plugin/kinesis/util/TestUtils.java b/plugin/trino-kinesis/src/test/java/io/trino/plugin/kinesis/util/TestUtils.java
@@ -30,7 +30,7 @@
 
 public final class TestUtils
 {
-    public static final String NONE_KEY = "NONE";
+    private static final String NONE_KEY = "NONE";
 
     private TestUtils() {}
 

diff --git a/plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisColumnHandle.java b/plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisColumnHandle.java
@@ -24,22 +24,11 @@
 import static com.google.common.base.MoreObjects.toStringHelper;
 import static java.util.Objects.requireNonNull;
 
-/**
- * Redis specific connector column handle.
- */
 public final class RedisColumnHandle
         implements DecoderColumnHandle, Comparable<RedisColumnHandle>
 {
     private final int ordinalPosition;
-
-    /**
-     * Column Name
-     */
     private final String name;
-
-    /**
-     * Column type
-     */
     private final Type type;
 
     /**
@@ -62,9 +51,6 @@ public final class RedisColumnHandle
      */
     private final boolean keyDecoder;
 
-    /**
-     * True if the column should be hidden.
-     */
     private final boolean hidden;
 
     /**

diff --git a/plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisDecoderModule.java b/plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisDecoderModule.java
@@ -34,9 +34,6 @@
 
 import static com.google.inject.Scopes.SINGLETON;
 
-/**
- * Redis decoder specific module. Installs the registry and all known decoder submodules.
- */
 public class RedisDecoderModule
         implements Module
 {