Add isNotNull to Domain

Convenience method for domain.getValues().isAll() && !domain.isNullAllowed(). This translates to IS NOT NULL.
trinodb · May 21, 2023 · cb09b22 · cb09b22
1 parent 150d340
commit cb09b22
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/core/trino-spi/src/main/java/io/trino/spi/predicate/Domain.java b/core/trino-spi/src/main/java/io/trino/spi/predicate/Domain.java
@@ -154,6 +154,11 @@ public boolean isOnlyNull()
         return values.isNone() && nullAllowed;
     }
 
+    public boolean isNotNull()
+    {
+        return values.isAll() && !nullAllowed;
+    }
+
     public Object getSingleValue()
     {
         if (!isSingleValue()) {

diff --git a/plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientSession.java b/plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientSession.java
@@ -511,7 +511,7 @@ else if (domain.isOnlyNull()) {
             else if (!domain.getValues().isNone() && domain.isNullAllowed()) {
                 // no restriction
             }
-            else if (domain.getValues().isAll() && !domain.isNullAllowed()) {
+            else if (domain.isNotNull()) {
                 builder.addPredicate(KuduPredicate.newIsNotNullPredicate(columnSchema));
             }
             else if (domain.isSingleValue()) {

diff --git a/plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java b/plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
@@ -502,7 +502,7 @@ private static Optional<Document> buildPredicate(MongoColumnHandle column, Domai
         if (domain.getValues().isNone() && domain.isNullAllowed()) {
             return Optional.of(documentOf(name, isNullPredicate()));
         }
-        if (domain.getValues().isAll() && !domain.isNullAllowed()) {
+        if (domain.isNotNull()) {
             return Optional.of(documentOf(name, isNotNullPredicate()));
         }