Opportunistically reuse instance in OperatorStats#summarize()

trinodb · Nov 12, 2021 · c9c711e · c9c711e
1 parent 387c444
commit c9c711e
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/core/trino-main/src/main/java/io/trino/operator/OperatorStats.java b/core/trino-main/src/main/java/io/trino/operator/OperatorStats.java
@@ -86,6 +86,7 @@ public class OperatorStats
 
     private final Optional<BlockedReason> blockedReason;
 
+    @Nullable
     private final OperatorInfo info;
 
     @JsonCreator
@@ -140,6 +141,7 @@ public OperatorStats(
 
             @JsonProperty("blockedReason") Optional<BlockedReason> blockedReason,
 
+            @Nullable
             @JsonProperty("info") OperatorInfo info)
     {
         this.stageId = stageId;
@@ -623,6 +625,10 @@ private static <T> Mergeable<T> mergeInfo(Mergeable<T> base, T other)
 
     public OperatorStats summarize()
     {
+        if (info == null || info.isFinal()) {
+            return this;
+        }
+        OperatorInfo info = null;
         return new OperatorStats(
                 stageId,
                 pipelineId,
@@ -663,6 +669,6 @@ public OperatorStats summarize()
                 peakTotalMemoryReservation,
                 spilledDataSize,
                 blockedReason,
-                (info != null && info.isFinal()) ? info : null);
+                info);
     }
 }