Migrate Connector.beginTransaction() implementations

trinodb · Nov 17, 2021 · bfcb5e8 · bfcb5e8
1 parent ab22da1
commit bfcb5e8
Show file tree

Hide file tree

Showing 37 changed files with 48 additions and 43 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/testing/TestingSession.java b/core/trino-main/src/main/java/io/trino/testing/TestingSession.java
@@ -94,7 +94,7 @@ private static Connector createTestSessionConnector()
         return new Connector()
         {
             @Override
-            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
             {
                 return new ConnectorTransactionHandle() {};
             }

diff --git a/core/trino-main/src/main/java/io/trino/transaction/InternalConnector.java b/core/trino-main/src/main/java/io/trino/transaction/InternalConnector.java
@@ -21,7 +21,7 @@ public interface InternalConnector
         extends Connector
 {
     @Override
-    default ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    default ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         throw new UnsupportedOperationException();
     }

diff --git a/core/trino-main/src/test/java/io/trino/connector/MockConnector.java b/core/trino-main/src/test/java/io/trino/connector/MockConnector.java
@@ -177,7 +177,7 @@ public class MockConnector
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return MockConnectorTransactionHandle.INSTANCE;
     }

diff --git a/core/trino-main/src/test/java/io/trino/execution/TestSetRoleTask.java b/core/trino-main/src/test/java/io/trino/execution/TestSetRoleTask.java
@@ -107,7 +107,7 @@ public void setUp()
         Connector systemRoleConnector = new Connector()
         {
             @Override
-            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
             {
                 return new ConnectorTransactionHandle() {};
             }

diff --git a/core/trino-main/src/test/java/io/trino/sql/analyzer/TestAnalyzer.java b/core/trino-main/src/test/java/io/trino/sql/analyzer/TestAnalyzer.java
@@ -5328,7 +5328,7 @@ private static Connector createTestingConnector()
             private final ConnectorMetadata metadata = new TestingMetadata();
 
             @Override
-            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
             {
                 return new ConnectorTransactionHandle() {};
             }

diff --git a/core/trino-main/src/test/java/io/trino/sql/planner/TestMaterializedViews.java b/core/trino-main/src/test/java/io/trino/sql/planner/TestMaterializedViews.java
@@ -236,7 +236,7 @@ private static Connector createTestingConnector()
             private final ConnectorMetadata metadata = new TestingMetadata();
 
             @Override
-            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
             {
                 return new ConnectorTransactionHandle() {};
             }

diff --git a/plugin/trino-accumulo/src/main/java/io/trino/plugin/accumulo/AccumuloConnector.java b/plugin/trino-accumulo/src/main/java/io/trino/plugin/accumulo/AccumuloConnector.java
@@ -82,7 +82,7 @@ public ConnectorMetadata getMetadata(ConnectorTransactionHandle transactionHandl
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_UNCOMMITTED, isolationLevel);
         ConnectorTransactionHandle transaction = new AccumuloTransactionHandle();

diff --git a/plugin/trino-atop/src/main/java/io/trino/plugin/atop/AtopConnector.java b/plugin/trino-atop/src/main/java/io/trino/plugin/atop/AtopConnector.java
@@ -53,7 +53,7 @@ public AtopConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return AtopTransactionHandle.INSTANCE;
     }

diff --git a/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcConnector.java b/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcConnector.java
@@ -88,7 +88,7 @@ public JdbcConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         JdbcTransactionHandle transaction = new JdbcTransactionHandle();

diff --git a/plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConnector.java b/plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConnector.java
@@ -48,7 +48,7 @@ public BigQueryConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         log.debug("beginTransaction(isolationLevel=%s, readOnly=%s)", isolationLevel, readOnly);
         checkConnectorSupports(READ_COMMITTED, isolationLevel);

diff --git a/plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleConnector.java b/plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleConnector.java
@@ -75,7 +75,7 @@ public BlackHoleConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return BlackHoleTransactionHandle.INSTANCE;
     }

diff --git a/plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraConnector.java b/plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraConnector.java
@@ -59,7 +59,7 @@ public CassandraConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_UNCOMMITTED, isolationLevel);
         return CassandraTransactionHandle.INSTANCE;

diff --git a/...ino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchConnector.java b/...ino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchConnector.java
@@ -56,7 +56,7 @@ public ElasticsearchConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         return ElasticsearchTransactionHandle.INSTANCE;

diff --git a/plugin/trino-example-http/src/main/java/io/trino/plugin/example/ExampleConnector.java b/plugin/trino-example-http/src/main/java/io/trino/plugin/example/ExampleConnector.java
@@ -48,7 +48,7 @@ public ExampleConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return INSTANCE;
     }

diff --git a/plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsConnector.java b/plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsConnector.java
@@ -48,7 +48,7 @@ public SheetsConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return INSTANCE;
     }

diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergConnector.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergConnector.java
@@ -181,7 +181,7 @@ public ConnectorAccessControl getAccessControl()
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(SERIALIZABLE, isolationLevel);
         ConnectorTransactionHandle transaction = new HiveTransactionHandle();

diff --git a/plugin/trino-jmx/src/main/java/io/trino/plugin/jmx/JmxConnector.java b/plugin/trino-jmx/src/main/java/io/trino/plugin/jmx/JmxConnector.java
@@ -66,7 +66,7 @@ public JmxRecordSetProvider getRecordSetProvider()
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         return JmxTransactionHandle.INSTANCE;

diff --git a/plugin/trino-kafka/src/main/java/io/trino/plugin/kafka/KafkaConnector.java b/plugin/trino-kafka/src/main/java/io/trino/plugin/kafka/KafkaConnector.java
@@ -64,7 +64,7 @@ public KafkaConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         return KafkaTransactionHandle.INSTANCE;

diff --git a/plugin/trino-kinesis/src/main/java/io/trino/plugin/kinesis/KinesisConnector.java b/plugin/trino-kinesis/src/main/java/io/trino/plugin/kinesis/KinesisConnector.java
@@ -58,7 +58,7 @@ public ConnectorMetadata getMetadata(ConnectorTransactionHandle transactionHandl
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean b)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         return KinesisTransactionHandle.INSTANCE;

diff --git a/plugin/trino-kinesis/src/test/java/io/trino/plugin/kinesis/TestKinesisPlugin.java b/plugin/trino-kinesis/src/test/java/io/trino/plugin/kinesis/TestKinesisPlugin.java
@@ -59,7 +59,7 @@ public void testCreateConnector()
         ConnectorMetadata md = c.getMetadata(KinesisTransactionHandle.INSTANCE);
         assertNotNull(md);
 
-        ConnectorTransactionHandle handle = c.beginTransaction(READ_COMMITTED, true);
+        ConnectorTransactionHandle handle = c.beginTransaction(READ_COMMITTED, true, true);
         assertTrue(handle instanceof KinesisTransactionHandle);
 
         c.shutdown();

diff --git a/plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduConnector.java b/plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduConnector.java
@@ -73,7 +73,7 @@ public KuduConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         return KuduTransactionHandle.INSTANCE;

diff --git a/plugin/trino-local-file/src/main/java/io/trino/plugin/localfile/LocalFileConnector.java b/plugin/trino-local-file/src/main/java/io/trino/plugin/localfile/LocalFileConnector.java
@@ -49,7 +49,7 @@ public LocalFileConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         return LocalFileTransactionHandle.INSTANCE;

diff --git a/plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryConnector.java b/plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryConnector.java
@@ -45,7 +45,7 @@ public MemoryConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return MemoryTransactionHandle.INSTANCE;
     }

diff --git a/plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoConnector.java b/plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoConnector.java
@@ -55,7 +55,7 @@ public MongoConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_UNCOMMITTED, isolationLevel);
         MongoTransactionHandle transaction = new MongoTransactionHandle();

diff --git a/plugin/trino-phoenix/src/main/java/io/trino/plugin/phoenix/PhoenixConnector.java b/plugin/trino-phoenix/src/main/java/io/trino/plugin/phoenix/PhoenixConnector.java
@@ -71,7 +71,7 @@ public PhoenixConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return new JdbcTransactionHandle();
     }

diff --git a/plugin/trino-phoenix5/src/main/java/io/trino/plugin/phoenix5/PhoenixConnector.java b/plugin/trino-phoenix5/src/main/java/io/trino/plugin/phoenix5/PhoenixConnector.java
@@ -71,7 +71,7 @@ public PhoenixConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return new JdbcTransactionHandle();
     }

diff --git a/plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConnector.java b/plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConnector.java
@@ -58,7 +58,7 @@ public PinotConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return PinotTransactionHandle.INSTANCE;
     }

diff --git a/plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusConnector.java b/plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusConnector.java
@@ -51,7 +51,7 @@ public PrometheusConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return INSTANCE;
     }

diff --git a/plugin/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/RaptorConnector.java b/plugin/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/RaptorConnector.java
@@ -118,7 +118,7 @@ public void start()
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         RaptorTransactionHandle transaction = new RaptorTransactionHandle();

diff --git a/.../trino-raptor-legacy/src/test/java/io/trino/plugin/raptor/legacy/TestRaptorConnector.java b/.../trino-raptor-legacy/src/test/java/io/trino/plugin/raptor/legacy/TestRaptorConnector.java
@@ -134,23 +134,23 @@ public void testMaintenanceBlocked()
         assertFalse(metadataDao.isMaintenanceBlockedLocked(tableId2));
 
         // begin delete for table1
-        ConnectorTransactionHandle txn1 = connector.beginTransaction(READ_COMMITTED, false);
+        ConnectorTransactionHandle txn1 = beginTransaction();
         ConnectorTableHandle handle1 = getTableHandle(connector.getMetadata(txn1), "test1");
         connector.getMetadata(txn1).beginDelete(SESSION, handle1);
 
         assertTrue(metadataDao.isMaintenanceBlockedLocked(tableId1));
         assertFalse(metadataDao.isMaintenanceBlockedLocked(tableId2));
 
         // begin delete for table2
-        ConnectorTransactionHandle txn2 = connector.beginTransaction(READ_COMMITTED, false);
+        ConnectorTransactionHandle txn2 = beginTransaction();
         ConnectorTableHandle handle2 = getTableHandle(connector.getMetadata(txn2), "test2");
         connector.getMetadata(txn2).beginDelete(SESSION, handle2);
 
         assertTrue(metadataDao.isMaintenanceBlockedLocked(tableId1));
         assertTrue(metadataDao.isMaintenanceBlockedLocked(tableId2));
 
         // begin another delete for table1
-        ConnectorTransactionHandle txn3 = connector.beginTransaction(READ_COMMITTED, false);
+        ConnectorTransactionHandle txn3 = beginTransaction();
         ConnectorTableHandle handle3 = getTableHandle(connector.getMetadata(txn3), "test1");
         connector.getMetadata(txn3).beginDelete(SESSION, handle3);
 
@@ -214,7 +214,7 @@ private void assertSplitShard(Type temporalType, String min, String max, int exp
                 .setPropertyMetadata(new RaptorSessionProperties(new StorageManagerConfig()).getSessionProperties())
                 .build();
 
-        ConnectorTransactionHandle transaction = connector.beginTransaction(READ_COMMITTED, false);
+        ConnectorTransactionHandle transaction = beginTransaction();
         connector.getMetadata(transaction).createTable(
                 SESSION,
                 new ConnectorTableMetadata(
@@ -224,7 +224,7 @@ private void assertSplitShard(Type temporalType, String min, String max, int exp
                 false);
         connector.commit(transaction);
 
-        ConnectorTransactionHandle txn1 = connector.beginTransaction(READ_COMMITTED, false);
+        ConnectorTransactionHandle txn1 = beginTransaction();
         ConnectorTableHandle handle1 = getTableHandle(connector.getMetadata(txn1), "test");
         ConnectorInsertTableHandle insertTableHandle = connector.getMetadata(txn1).beginInsert(session, handle1);
         ConnectorPageSink raptorPageSink = connector.getPageSinkProvider().createPageSink(txn1, session, insertTableHandle);
@@ -256,7 +256,7 @@ else if (temporalType.equals(DATE)) {
 
     private long createTable(String name)
     {
-        ConnectorTransactionHandle transaction = connector.beginTransaction(READ_COMMITTED, false);
+        ConnectorTransactionHandle transaction = beginTransaction();
         connector.getMetadata(transaction).createTable(
                 SESSION,
                 new ConnectorTableMetadata(
@@ -265,12 +265,17 @@ private long createTable(String name)
                 false);
         connector.commit(transaction);
 
-        transaction = connector.beginTransaction(READ_COMMITTED, false);
+        transaction = beginTransaction();
         ConnectorTableHandle tableHandle = getTableHandle(connector.getMetadata(transaction), name);
         connector.commit(transaction);
         return ((RaptorTableHandle) tableHandle).getTableId();
     }
 
+    private ConnectorTransactionHandle beginTransaction()
+    {
+        return connector.beginTransaction(READ_COMMITTED, false, true);
+    }
+
     private static ConnectorTableHandle getTableHandle(ConnectorMetadata metadata, String name)
     {
         return metadata.getTableHandle(SESSION, new SchemaTableName("test", name));

diff --git a/plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisConnector.java b/plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisConnector.java
@@ -49,7 +49,7 @@ public RedisConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         checkConnectorSupports(READ_COMMITTED, isolationLevel);
         return RedisTransactionHandle.INSTANCE;

diff --git a/plugin/trino-thrift/src/main/java/io/trino/plugin/thrift/ThriftConnector.java b/plugin/trino-thrift/src/main/java/io/trino/plugin/thrift/ThriftConnector.java
@@ -57,7 +57,7 @@ public ThriftConnector(
     }
 
     @Override
-    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+    public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
     {
         return ThriftTransactionHandle.INSTANCE;
     }

diff --git a/plugin/trino-tpcds/src/main/java/io/trino/plugin/tpcds/TpcdsConnectorFactory.java b/plugin/trino-tpcds/src/main/java/io/trino/plugin/tpcds/TpcdsConnectorFactory.java
@@ -68,7 +68,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
         return new Connector()
         {
             @Override
-            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
             {
                 return TpcdsTransactionHandle.INSTANCE;
             }

diff --git a/plugin/trino-tpch/src/main/java/io/trino/plugin/tpch/TpchConnectorFactory.java b/plugin/trino-tpch/src/main/java/io/trino/plugin/tpch/TpchConnectorFactory.java
@@ -89,7 +89,7 @@ public Connector create(String catalogName, Map<String, String> properties, Conn
         return new Connector()
         {
             @Override
-            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
             {
                 return TpchTransactionHandle.INSTANCE;
             }

diff --git a/testing/trino-testing/src/main/java/io/trino/testing/tpch/IndexedTpchConnectorFactory.java b/testing/trino-testing/src/main/java/io/trino/testing/tpch/IndexedTpchConnectorFactory.java
@@ -73,7 +73,7 @@ public Connector create(String catalogName, Map<String, String> properties, Conn
         return new Connector()
         {
             @Override
-            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
             {
                 return TpchTransactionHandle.INSTANCE;
             }

diff --git a/testing/trino-tests/src/test/java/io/trino/execution/TestBeginQuery.java b/testing/trino-tests/src/test/java/io/trino/execution/TestBeginQuery.java
@@ -191,7 +191,7 @@ private TestConnector(ConnectorMetadata metadata)
         }
 
         @Override
-        public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+        public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
         {
             return TestingTransactionHandle.create();
         }

diff --git a/testing/trino-tests/src/test/java/io/trino/execution/TestCoordinatorDynamicFiltering.java b/testing/trino-tests/src/test/java/io/trino/execution/TestCoordinatorDynamicFiltering.java
@@ -448,7 +448,7 @@ private TestConnector(ConnectorMetadata metadata)
         }
 
         @Override
-        public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
+        public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
         {
             return TestingTransactionHandle.create();
         }