Implement mayHaveNull() for Dictionary, RLE, and GroupById Blocks

trinodb · Jul 7, 2021 · bc1d5ba · bc1d5ba
1 parent 17cf25f
commit bc1d5ba
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/operator/GroupByIdBlock.java b/core/trino-main/src/main/java/io/trino/operator/GroupByIdBlock.java
@@ -165,6 +165,12 @@ public Block getSingleValueBlock(int position)
         return block.getSingleValueBlock(position);
     }
 
+    @Override
+    public boolean mayHaveNull()
+    {
+        return block.mayHaveNull();
+    }
+
     @Override
     public boolean isNull(int position)
     {

diff --git a/core/trino-spi/src/main/java/io/trino/spi/block/DictionaryBlock.java b/core/trino-spi/src/main/java/io/trino/spi/block/DictionaryBlock.java
@@ -365,6 +365,12 @@ public Block copyRegion(int position, int length)
         return dictionaryBlock.compact();
     }
 
+    @Override
+    public boolean mayHaveNull()
+    {
+        return positionCount > 0 && dictionary.mayHaveNull();
+    }
+
     @Override
     public boolean isNull(int position)
     {

diff --git a/core/trino-spi/src/main/java/io/trino/spi/block/RunLengthEncodedBlock.java b/core/trino-spi/src/main/java/io/trino/spi/block/RunLengthEncodedBlock.java
@@ -271,6 +271,12 @@ public Block getSingleValueBlock(int position)
         return value;
     }
 
+    @Override
+    public boolean mayHaveNull()
+    {
+        return positionCount > 0 && value.isNull(0);
+    }
+
     @Override
     public boolean isNull(int position)
     {