Skip to content

Commit

Permalink
Remove unnecessary calls to toString()
Browse files Browse the repository at this point in the history
  • Loading branch information
martint authored and losipiuk committed Dec 22, 2023
1 parent 7b660f1 commit b2e98e9
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,14 @@ synchronized void updateTaskInfo(TaskInfo newTaskInfo)
TaskStatus newRemoteTaskStatus = newTaskInfo.getTaskStatus();

if (!newRemoteTaskStatus.getTaskId().equals(taskId)) {
log.debug("Task ID mismatch on remote task status. Member task ID is %s, but remote task ID is %s. This will confuse finalTaskInfo listeners.", taskId.toString(), newRemoteTaskStatus.getTaskId().toString());
log.debug("Task ID mismatch on remote task status. Member task ID is %s, but remote task ID is %s. This will confuse finalTaskInfo listeners.", taskId, newRemoteTaskStatus.getTaskId());
}

if (localTaskStatus.getState().isDone() && newRemoteTaskStatus.getState().isDone() && localTaskStatus.getState() != newRemoteTaskStatus.getState()) {
// prefer local
newTaskInfo = newTaskInfo.withTaskStatus(localTaskStatus);
if (!localTaskStatus.getTaskId().equals(taskId)) {
log.debug("Task ID mismatch on local task status. Member task ID is %s, but status-fetcher ID is %s. This will confuse finalTaskInfo listeners.", taskId.toString(), newRemoteTaskStatus.getTaskId().toString());
log.debug("Task ID mismatch on local task status. Member task ID is %s, but status-fetcher ID is %s. This will confuse finalTaskInfo listeners.", taskId, newRemoteTaskStatus.getTaskId());
}
}

Expand All @@ -269,7 +269,7 @@ synchronized void updateTaskInfo(TaskInfo newTaskInfo)
if (newTaskInfo.getTaskStatus().getState().isDone()) {
boolean wasSet = spoolingOutputStats.compareAndSet(null, newTaskInfo.getOutputBuffers().getSpoolingOutputStats().orElse(null));
if (wasSet && spoolingOutputStats.get() == null) {
log.debug("Task %s was updated to null spoolingOutputStats. Future calls to retrieveAndDropSpoolingOutputStats will fail.", taskId.toString());
log.debug("Task %s was updated to null spoolingOutputStats. Future calls to retrieveAndDropSpoolingOutputStats will fail.", taskId);
}
newTaskInfo = newTaskInfo.pruneSpoolingOutputStats();
}
Expand Down

0 comments on commit b2e98e9

Please sign in to comment.