-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor KafkaInternalFieldDescription to KafkaInternalFieldManager
The KafkaInternalFieldManager creates the internalFields map in the consructor where the TypeManager can be used. Signed-off-by: Sven Pfennig <[email protected]>
- Loading branch information
Showing
5 changed files
with
186 additions
and
146 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 0 additions & 138 deletions
138
presto-kafka/src/main/java/io/prestosql/plugin/kafka/KafkaInternalFieldDescription.java
This file was deleted.
Oops, something went wrong.
167 changes: 167 additions & 0 deletions
167
presto-kafka/src/main/java/io/prestosql/plugin/kafka/KafkaInternalFieldManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.prestosql.plugin.kafka; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import com.google.inject.Inject; | ||
| import io.prestosql.spi.connector.ColumnMetadata; | ||
| import io.prestosql.spi.type.BigintType; | ||
| import io.prestosql.spi.type.BooleanType; | ||
| import io.prestosql.spi.type.Type; | ||
| import io.prestosql.spi.type.TypeManager; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.Optional; | ||
|
|
||
| import static io.prestosql.spi.type.VarcharType.createUnboundedVarcharType; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class KafkaInternalFieldManager | ||
| { | ||
| /** | ||
| * <tt>_partition_id</tt> - Kafka partition id. | ||
| */ | ||
| public static final String PARTITION_ID_FIELD = "_partition_id"; | ||
|
|
||
| /** | ||
| * <tt>_partition_offset</tt> - The current offset of the message in the partition. | ||
| */ | ||
| public static final String PARTITION_OFFSET_FIELD = "_partition_offset"; | ||
|
|
||
| /** | ||
| * <tt>_message_corrupt</tt> - True if the row converter could not read the a message. May be null if the row converter does not set a value (e.g. the dummy row converter does not). | ||
| */ | ||
| public static final String MESSAGE_CORRUPT_FIELD = "_message_corrupt"; | ||
|
|
||
| /** | ||
| * <tt>_message</tt> - Represents the full topic as a text column. Format is UTF-8 which may be wrong for some topics. TODO: make charset configurable. | ||
| */ | ||
| public static final String MESSAGE_FIELD = "_message"; | ||
|
|
||
| /** | ||
| * <tt>_message_length</tt> - length in bytes of the message. | ||
| */ | ||
| public static final String MESSAGE_LENGTH_FIELD = "_message_length"; | ||
|
|
||
| /** | ||
| * <tt>_key_corrupt</tt> - True if the row converter could not read the a key. May be null if the row converter does not set a value (e.g. the dummy row converter does not). | ||
| */ | ||
| public static final String KEY_CORRUPT_FIELD = "_key_corrupt"; | ||
|
|
||
| /** | ||
| * <tt>_key</tt> - Represents the key as a text column. Format is UTF-8 which may be wrong for topics. TODO: make charset configurable. | ||
| */ | ||
| public static final String KEY_FIELD = "_key"; | ||
|
|
||
| /** | ||
| * <tt>_key_length</tt> - length in bytes of the key. | ||
| */ | ||
| public static final String KEY_LENGTH_FIELD = "_key_length"; | ||
|
|
||
| public static class InternalField | ||
| { | ||
| private final String columnName; | ||
| private final String comment; | ||
| private final Type type; | ||
|
|
||
| InternalField(String columnName, String comment, Type type) | ||
| { | ||
| this.columnName = requireNonNull(columnName, "columnName is null"); | ||
| this.comment = requireNonNull(comment, "comment is null"); | ||
| this.type = requireNonNull(type, "type is null"); | ||
| } | ||
|
|
||
| public String getColumnName() | ||
| { | ||
| return columnName; | ||
| } | ||
|
|
||
| private Type getType() | ||
| { | ||
| return type; | ||
| } | ||
|
|
||
| KafkaColumnHandle getColumnHandle(int index, boolean hidden) | ||
| { | ||
| return new KafkaColumnHandle( | ||
| getColumnName(), | ||
| getType(), | ||
| null, | ||
| null, | ||
| null, | ||
| false, | ||
| hidden, | ||
| true); | ||
| } | ||
|
|
||
| ColumnMetadata getColumnMetadata(boolean hidden) | ||
| { | ||
| return ColumnMetadata.builder() | ||
| .setName(columnName) | ||
| .setType(type) | ||
| .setComment(Optional.ofNullable(columnName)) | ||
| .setHidden(hidden) | ||
| .build(); | ||
| } | ||
| } | ||
|
|
||
| private final Map<String, InternalField> internalFields; | ||
|
|
||
| @Inject | ||
| public KafkaInternalFieldManager(TypeManager typeManager) | ||
| { | ||
| internalFields = new ImmutableMap.Builder<String, InternalField>() | ||
| .put(PARTITION_ID_FIELD, new InternalField( | ||
| PARTITION_ID_FIELD, | ||
| "Partition Id", | ||
| BigintType.BIGINT)) | ||
| .put(PARTITION_OFFSET_FIELD, new InternalField( | ||
| PARTITION_OFFSET_FIELD, | ||
| "Offset for the message within the partition", | ||
| BigintType.BIGINT)) | ||
| .put(MESSAGE_CORRUPT_FIELD, new InternalField( | ||
| MESSAGE_CORRUPT_FIELD, | ||
| "Message data is corrupt", | ||
| BooleanType.BOOLEAN)) | ||
| .put(MESSAGE_FIELD, new InternalField( | ||
| MESSAGE_FIELD, | ||
| "Message text", | ||
| createUnboundedVarcharType())) | ||
| .put(MESSAGE_LENGTH_FIELD, new InternalField( | ||
| MESSAGE_LENGTH_FIELD, | ||
| "Total number of message bytes", | ||
| BigintType.BIGINT)) | ||
| .put(KEY_CORRUPT_FIELD, new InternalField( | ||
| KEY_CORRUPT_FIELD, | ||
| "Key data is corrupt", | ||
| BooleanType.BOOLEAN)) | ||
| .put(KEY_FIELD, new InternalField( | ||
| KEY_FIELD, | ||
| "Key text", | ||
| createUnboundedVarcharType())) | ||
| .put(KEY_LENGTH_FIELD, new InternalField( | ||
| KEY_LENGTH_FIELD, | ||
| "Total number of key bytes", | ||
| BigintType.BIGINT)) | ||
| .build(); | ||
| } | ||
|
|
||
| /** | ||
| * @return Map of {@link InternalField} for each internal field. | ||
| */ | ||
| public Map<String, InternalField> getInternalFields() | ||
| { | ||
| return internalFields; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters