Skip to content

Commit

Permalink
Fix filterDataMappingSmokeTestData in ClickHouse
Browse files Browse the repository at this point in the history
  • Loading branch information
ebyhr committed Jun 14, 2023
1 parent f79196f commit a221b13
Showing 1 changed file with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -580,8 +580,14 @@ protected Optional<DataMappingTestSetup> filterDataMappingSmokeTestData(DataMapp
return Optional.empty();

case "date":
// TODO (https://github.com/trinodb/trino/issues/7101) enable the test
return Optional.empty();
// The connector supports date type, but these values are unsupported in ClickHouse
// See BaseClickHouseTypeMapping for additional test coverage
if (dataMappingTestSetup.getSampleValueLiteral().equals("DATE '0001-01-01'") ||
dataMappingTestSetup.getSampleValueLiteral().equals("DATE '1582-10-05'") ||
dataMappingTestSetup.getHighValueLiteral().equals("DATE '9999-12-31'")) {
return Optional.empty();
}
return Optional.of(dataMappingTestSetup);

case "time":
case "time(6)":
Expand Down

0 comments on commit a221b13

Please sign in to comment.