Skip to content

Commit

Permalink
Extract LayoutConstraintEvaluator from PushPredicateIntoTableScan
Browse files Browse the repository at this point in the history
  • Loading branch information
homar authored and findepi committed Nov 22, 2021
1 parent 61c220b commit a0fb364
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 46 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.trino.sql.planner;

import com.google.common.collect.ImmutableMap;
import io.trino.Session;
import io.trino.metadata.Metadata;
import io.trino.operator.scalar.TryFunction;
import io.trino.spi.connector.ColumnHandle;
import io.trino.spi.predicate.NullableValue;
import io.trino.sql.tree.Expression;
import io.trino.sql.tree.NullLiteral;

import java.util.Map;
import java.util.Set;

import static com.google.common.collect.ImmutableSet.toImmutableSet;
import static com.google.common.collect.Sets.intersection;
import static java.util.Objects.requireNonNull;

public class LayoutConstraintEvaluator
{
private final Map<Symbol, ColumnHandle> assignments;
private final ExpressionInterpreter evaluator;
private final Set<ColumnHandle> arguments;

public LayoutConstraintEvaluator(Metadata metadata, TypeAnalyzer typeAnalyzer, Session session, TypeProvider types, Map<Symbol, ColumnHandle> assignments, Expression expression)
{
this.assignments = ImmutableMap.copyOf(requireNonNull(assignments, "assignments is null"));
evaluator = new ExpressionInterpreter(expression, metadata, session, typeAnalyzer.getTypes(session, types, expression));
arguments = SymbolsExtractor.extractUnique(expression).stream()
.map(assignments::get)
.collect(toImmutableSet());
}

public Set<ColumnHandle> getArguments()
{
return arguments;
}

public boolean isCandidate(Map<ColumnHandle, NullableValue> bindings)
{
if (intersection(bindings.keySet(), arguments).isEmpty()) {
return true;
}
LookupSymbolResolver inputs = new LookupSymbolResolver(assignments, bindings);

// Skip pruning if evaluation fails in a recoverable way. Failing here can cause
// spurious query failures for partitions that would otherwise be filtered out.
Object optimized = TryFunction.evaluate(() -> evaluator.optimize(inputs), true);

// If any conjuncts evaluate to FALSE or null, then the whole predicate will never be true and so the partition should be pruned
return !(Boolean.FALSE.equals(optimized) || optimized == null || optimized instanceof NullLiteral);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,37 +25,29 @@
import io.trino.metadata.TableLayoutResult;
import io.trino.metadata.TableProperties;
import io.trino.metadata.TableProperties.TablePartitioning;
import io.trino.operator.scalar.TryFunction;
import io.trino.spi.connector.ColumnHandle;
import io.trino.spi.connector.Constraint;
import io.trino.spi.connector.ConstraintApplicationResult;
import io.trino.spi.predicate.NullableValue;
import io.trino.spi.predicate.TupleDomain;
import io.trino.spi.type.TypeOperators;
import io.trino.sql.planner.DomainTranslator;
import io.trino.sql.planner.ExpressionInterpreter;
import io.trino.sql.planner.LookupSymbolResolver;
import io.trino.sql.planner.LayoutConstraintEvaluator;
import io.trino.sql.planner.Symbol;
import io.trino.sql.planner.SymbolAllocator;
import io.trino.sql.planner.SymbolsExtractor;
import io.trino.sql.planner.TypeAnalyzer;
import io.trino.sql.planner.TypeProvider;
import io.trino.sql.planner.iterative.Rule;
import io.trino.sql.planner.plan.FilterNode;
import io.trino.sql.planner.plan.PlanNode;
import io.trino.sql.planner.plan.TableScanNode;
import io.trino.sql.planner.plan.ValuesNode;
import io.trino.sql.tree.Expression;
import io.trino.sql.tree.NullLiteral;

import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.Set;

import static com.google.common.base.Verify.verify;
import static com.google.common.collect.ImmutableSet.toImmutableSet;
import static com.google.common.collect.Sets.intersection;
import static io.trino.SystemSessionProperties.isAllowPushdownIntoConnectors;
import static io.trino.matching.Capture.newCapture;
import static io.trino.metadata.TableLayoutResult.computeEnforced;
Expand Down Expand Up @@ -346,41 +338,4 @@ static Expression createResultingPredicate(

return expression;
}

private static class LayoutConstraintEvaluator
{
private final Map<Symbol, ColumnHandle> assignments;
private final ExpressionInterpreter evaluator;
private final Set<ColumnHandle> arguments;

public LayoutConstraintEvaluator(Metadata metadata, TypeAnalyzer typeAnalyzer, Session session, TypeProvider types, Map<Symbol, ColumnHandle> assignments, Expression expression)
{
this.assignments = assignments;

evaluator = new ExpressionInterpreter(expression, metadata, session, typeAnalyzer.getTypes(session, types, expression));
arguments = SymbolsExtractor.extractUnique(expression).stream()
.map(assignments::get)
.collect(toImmutableSet());
}

public Set<ColumnHandle> getArguments()
{
return arguments;
}

private boolean isCandidate(Map<ColumnHandle, NullableValue> bindings)
{
if (intersection(bindings.keySet(), arguments).isEmpty()) {
return true;
}
LookupSymbolResolver inputs = new LookupSymbolResolver(assignments, bindings);

// Skip pruning if evaluation fails in a recoverable way. Failing here can cause
// spurious query failures for partitions that would otherwise be filtered out.
Object optimized = TryFunction.evaluate(() -> evaluator.optimize(inputs), true);

// If any conjuncts evaluate to FALSE or null, then the whole predicate will never be true and so the partition should be pruned
return !(Boolean.FALSE.equals(optimized) || optimized == null || optimized instanceof NullLiteral);
}
}
}

0 comments on commit a0fb364

Please sign in to comment.