Enable Error Prone check: CheckedExceptionNotThrown

The issue with this is that: * This is an experimental checker * It has a huge number of false negatives Regarding the second point, it may be that making it more accurate would make it unviably slow (the equivalent inspection in IntelliJ IDEA takes a lot of time, has to look at the whole code base - it's definitely not local - and has to be done repeatedly until nothing more is found). But perhaps it's still useful.
trinodb · Aug 30, 2022 · 9d1c7a6 · 9d1c7a6
1 parent 5120f3f
commit 9d1c7a6
Show file tree

Hide file tree

Showing 16 changed files with 9 additions and 35 deletions.
diff --git a/client/trino-cli/src/main/java/io/trino/cli/InputReader.java b/client/trino-cli/src/main/java/io/trino/cli/InputReader.java
@@ -43,7 +43,6 @@ public class InputReader
     private final LineReader reader;
 
     public InputReader(ClientOptions.EditingMode editingMode, Path historyFile, boolean disableAutoSuggestion, Completer... completers)
-            throws IOException
     {
         reader = LineReaderBuilder.builder()
                 .terminal(TerminalUtils.getTerminal())

diff --git a/client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoDatabaseMetaData.java b/client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoDatabaseMetaData.java
@@ -1569,7 +1569,6 @@ private static void optionalStringInFilter(List<String> filters, String columnNa
 
     @Nullable
     private String escapeIfNecessary(@Nullable String namePattern)
-            throws SQLException
     {
         return escapeIfNecessary(assumeLiteralNamesInMetadataCallsForNonConformingClients, assumeLiteralUnderscoreInMetadataCallsForNonConformingClients, namePattern);
     }

diff --git a/client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoResultSet.java b/client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoResultSet.java
@@ -63,7 +63,6 @@ static TrinoResultSet create(Statement statement, StatementClient client, long m
     }
 
     private TrinoResultSet(Statement statement, StatementClient client, List<Column> columns, long maxRows, Consumer<QueryStats> progressCallback, WarningsManager warningsManager)
-            throws SQLException
     {
         super(
                 Optional.of(requireNonNull(statement, "statement is null")),

diff --git a/.../trino-main/src/main/java/io/trino/operator/aggregation/ArbitraryAggregationFunction.java b/.../trino-main/src/main/java/io/trino/operator/aggregation/ArbitraryAggregationFunction.java
@@ -39,7 +39,6 @@ public static void input(
             @AggregationState("T") InOut state,
             @BlockPosition @SqlType("T") Block block,
             @BlockIndex int position)
-            throws Throwable
     {
         if (state.isNull()) {
             state.set(block, position);
@@ -50,7 +49,6 @@ public static void input(
     public static void combine(
             @AggregationState("T") InOut state,
             @AggregationState("T") InOut otherState)
-            throws Throwable
     {
         if (state.isNull()) {
             state.set(otherState);

diff --git a/core/trino-main/src/test/java/io/trino/server/security/TestResourceSecurity.java b/core/trino-main/src/test/java/io/trino/server/security/TestResourceSecurity.java
@@ -35,7 +35,6 @@
 import io.trino.server.HttpRequestSessionContextFactory;
 import io.trino.server.ProtocolConfig;
 import io.trino.server.protocol.PreparedStatementEncoder;
-import io.trino.server.security.oauth2.ChallengeFailedException;
 import io.trino.server.security.oauth2.OAuth2Client;
 import io.trino.server.security.oauth2.TokenPairSerializer;
 import io.trino.server.security.oauth2.TokenPairSerializer.TokenPair;
@@ -912,7 +911,6 @@ public Optional<Map<String, Object>> getClaims(String accessToken)
 
                 @Override
                 public Response refreshTokens(String refreshToken)
-                        throws ChallengeFailedException
                 {
                     throw new UnsupportedOperationException("refresh tokens not supported");
                 }

diff --git a/...no-accumulo/src/main/java/io/trino/plugin/accumulo/metadata/ZooKeeperMetadataManager.java b/...no-accumulo/src/main/java/io/trino/plugin/accumulo/metadata/ZooKeeperMetadataManager.java
@@ -338,7 +338,6 @@ private AccumuloTable toAccumuloTable(byte[] data)
     }
 
     private AccumuloView toAccumuloView(byte[] data)
-            throws IOException
     {
         return parseJson(mapper, data, AccumuloView.class);
     }

diff --git a/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/LazyConnectionFactory.java b/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/LazyConnectionFactory.java
@@ -39,6 +39,7 @@ public LazyConnectionFactory(@ForLazyConnectionFactory ConnectionFactory delegat
     }
 
     @Override
+    @SuppressWarnings("CheckedExceptionNotThrown") // preserve the "throws" contract of the interface declaration
     public Connection openConnection(ConnectorSession session)
             throws SQLException
     {

diff --git a/plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/TestingScyllaServer.java b/plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/TestingScyllaServer.java
@@ -52,13 +52,11 @@ public class TestingScyllaServer
     private final CassandraSession session;
 
     public TestingScyllaServer()
-            throws Exception
     {
         this("2.2.0");
     }
 
     public TestingScyllaServer(String version)
-            throws Exception
     {
         container = new GenericContainer<>("scylladb/scylla:" + version)
                 .withCommand("--smp", "1") // Limit SMP to run in a machine having many cores https://github.com/scylladb/scylla/issues/5638

diff --git a/...trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/AddFileEntry.java b/...trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/AddFileEntry.java
@@ -88,7 +88,7 @@ else if (stats.isPresent()) {
             try {
                 resultParsedStats = Optional.ofNullable(DeltaLakeJsonFileStatistics.create(stats.get()));
             }
-            catch (JsonProcessingException e) {
+            catch (RuntimeException e) {
                 LOG.debug(
                         e,
                         "File level stats could not be parsed and will be ignored. The JSON string was: %s",

diff --git a/...lta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogParser.java b/...lta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogParser.java
@@ -14,7 +14,6 @@
 package io.trino.plugin.deltalake.transactionlog;
 
 import com.fasterxml.jackson.core.JsonParseException;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import io.airlift.json.ObjectMapperProvider;
@@ -131,7 +130,6 @@ private TransactionLogParser() {}
             .withResolverStyle(ResolverStyle.STRICT);
 
     public static DeltaLakeTransactionLogEntry parseJson(String json)
-            throws JsonProcessingException
     {
         // lines are json strings followed by 'x' in some Databricks versions of Delta
         if (json.endsWith("x")) {

diff --git a/...java/io/trino/plugin/deltalake/transactionlog/statistics/DeltaLakeJsonFileStatistics.java b/...java/io/trino/plugin/deltalake/transactionlog/statistics/DeltaLakeJsonFileStatistics.java
@@ -15,7 +15,6 @@
 
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import io.airlift.json.ObjectMapperProvider;
 import io.airlift.log.Logger;
@@ -61,7 +60,6 @@ public class DeltaLakeJsonFileStatistics
     private final Optional<Map<CanonicalColumnName, Object>> nullCount;
 
     public static DeltaLakeJsonFileStatistics create(String jsonStatistics)
-            throws JsonProcessingException
     {
         return parseJson(OBJECT_MAPPER, jsonStatistics, DeltaLakeJsonFileStatistics.class);
     }

diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestBackgroundHiveSplitLoader.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestBackgroundHiveSplitLoader.java
@@ -264,7 +264,6 @@ protected boolean isSplitable(FileSystem fs, Path filename)
 
         @Override
         public RecordReader<Void, Void> getRecordReader(InputSplit inputSplit, JobConf jobConf, Reporter reporter)
-                throws IOException
         {
             throw new UnsupportedOperationException();
         }

diff --git a/plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSplitManager.java b/plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSplitManager.java
@@ -17,7 +17,6 @@
 import com.google.common.collect.Lists;
 import io.airlift.http.client.HttpUriBuilder;
 import io.airlift.units.Duration;
-import io.trino.spi.TrinoException;
 import io.trino.spi.connector.ColumnHandle;
 import io.trino.spi.connector.ConnectorSession;
 import io.trino.spi.connector.ConnectorSplit;
@@ -38,7 +37,6 @@
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 import java.net.URI;
-import java.net.URISyntaxException;
 import java.time.Instant;
 import java.util.List;
 import java.util.Map;
@@ -48,7 +46,6 @@
 import java.util.stream.IntStream;
 
 import static io.trino.plugin.prometheus.PrometheusClient.TIMESTAMP_COLUMN_TYPE;
-import static io.trino.plugin.prometheus.PrometheusErrorCode.PROMETHEUS_UNKNOWN_ERROR;
 import static io.trino.spi.type.DateTimeEncoding.unpackMillisUtc;
 import static java.time.Instant.ofEpochMilli;
 import static java.util.Objects.requireNonNull;
@@ -93,24 +90,17 @@ public ConnectorSplitSource getSplits(
         }
         List<ConnectorSplit> splits = generateTimesForSplits(prometheusClock.now(), maxQueryRangeDuration, queryChunkSizeDuration, tableHandle)
                 .stream()
-                .map(time -> {
-                    try {
-                        return new PrometheusSplit(buildQuery(
-                                prometheusURI,
-                                time,
-                                table.getName(),
-                                queryChunkSizeDuration).toString());
-                    }
-                    catch (URISyntaxException e) {
-                        throw new TrinoException(PROMETHEUS_UNKNOWN_ERROR, "split URI invalid: " + e.getMessage());
-                    }
-                }).collect(Collectors.toList());
+                .map(time -> new PrometheusSplit(buildQuery(
+                        prometheusURI,
+                        time,
+                        table.getName(),
+                        queryChunkSizeDuration).toString()))
+                .collect(Collectors.toList());
         return new FixedSplitSource(splits);
     }
 
     // HttpUriBuilder handles URI encode
     private static URI buildQuery(URI baseURI, String time, String metricName, Duration queryChunkSizeDuration)
-            throws URISyntaxException
     {
         return HttpUriBuilder.uriBuilderFrom(baseURI)
                 .appendPath("api/v1/query")

diff --git a/...n/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerConnectionFactory.java b/...n/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerConnectionFactory.java
@@ -83,7 +83,6 @@ private void prepare(Connection connection)
     }
 
     private boolean hasSnapshotIsolationEnabled(Connection connection)
-            throws SQLException
     {
         try {
             return snapshotIsolationEnabled.get(SnapshotIsolationEnabledCacheKey.INSTANCE, () -> {

diff --git a/pom.xml b/pom.xml
@@ -2014,6 +2014,7 @@
                                     -Xplugin:ErrorProne \
                                     -Xep:BadInstanceof:ERROR \
                                     -Xep:BoxedPrimitiveConstructor:ERROR \
+                                    -Xep:CheckedExceptionNotThrown:ERROR \
                                     -Xep:ClassCanBeStatic:ERROR \
                                     -Xep:CompareToZero:ERROR \
                                     -Xep:DefaultCharset:ERROR \

diff --git a/...rino-product-tests/src/main/java/io/trino/tests/product/hive/TestHivePropertiesTable.java b/...rino-product-tests/src/main/java/io/trino/tests/product/hive/TestHivePropertiesTable.java
@@ -16,7 +16,6 @@
 import io.trino.tempto.assertions.QueryAssert.Row;
 import org.testng.annotations.Test;
 
-import java.sql.SQLException;
 import java.util.List;
 
 import static com.google.common.collect.ImmutableList.toImmutableList;
@@ -77,7 +76,6 @@ public void testHiveViewPropertiesTable()
     }
 
     private static List<String> getTablePropertiesOnHive(String tableName)
-            throws SQLException
     {
         return onHive().executeQuery("SHOW TBLPROPERTIES " + tableName).rows().stream()
                 .map(row -> (String) row.get(1))
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         private TrinoResultSet(Statement statement, StatementClient client, List<Column> columns, long maxRows, Consumer<QueryStats> progressCallback, WarningsManager warningsManager)
-                throws SQLException
         {
             super(
                     Optional.of(requireNonNull(statement, "statement is null")),
@@ Expand Down @@