Remove obsolete suppressions

trinodb · Aug 27, 2023 · 945cb41 · 945cb41
1 parent 4490238
commit 945cb41
Show file tree

Hide file tree

Showing 11 changed files with 2 additions and 15 deletions.
diff --git a/client/trino-cli/src/test/java/io/trino/cli/TestVerticalRecordPrinter.java b/client/trino-cli/src/test/java/io/trino/cli/TestVerticalRecordPrinter.java
@@ -24,7 +24,6 @@
 import static io.trino.cli.TestAlignedTablePrinter.rows;
 import static org.testng.Assert.assertEquals;
 
-@SuppressWarnings("Duplicates")
 public class TestVerticalRecordPrinter
 {
     @Test

diff --git a/client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoConnection.java b/client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoConnection.java
@@ -325,7 +325,6 @@ public void setTransactionIsolation(int level)
         isolationLevel.set(level);
     }
 
-    @SuppressWarnings("MagicConstant")
     @Override
     public int getTransactionIsolation()
             throws SQLException

diff --git a/lib/trino-record-decoder/src/main/java/io/trino/decoder/csv/CsvColumnDecoder.java b/lib/trino-record-decoder/src/main/java/io/trino/decoder/csv/CsvColumnDecoder.java
@@ -92,7 +92,6 @@ public boolean isNull()
                 return tokens[columnIndex].isEmpty();
             }
 
-            @SuppressWarnings("SimplifiableConditionalExpression")
             @Override
             public boolean getBoolean()
             {

diff --git a/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcRecordCursor.java b/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcRecordCursor.java
@@ -268,7 +268,6 @@ public boolean isNull(int field)
         }
     }
 
-    @SuppressWarnings("UnusedDeclaration")
     @Override
     public void close()
     {

diff --git a/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/compaction/HudiCompactionOperation.java b/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/compaction/HudiCompactionOperation.java
@@ -219,7 +219,6 @@ public HudiCompactionOperation.Builder setMetrics(Map<String, Double> metrics)
             return this;
         }
 
-        @SuppressWarnings("unchecked")
         public HudiCompactionOperation build()
         {
             return new HudiCompactionOperation(

diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/PartitionFields.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/PartitionFields.java
@@ -72,17 +72,14 @@ public static PartitionSpec parsePartitionFields(Schema schema, List<String> fie
 
     public static void parsePartitionField(PartitionSpec.Builder builder, String field)
     {
-        @SuppressWarnings("PointlessBooleanExpression")
-        boolean matched = false ||
-                tryMatch(field, IDENTITY_PATTERN, match -> builder.identity(fromIdentifierToColumn(match.group()))) ||
+        boolean matched = tryMatch(field, IDENTITY_PATTERN, match -> builder.identity(fromIdentifierToColumn(match.group()))) ||
                 tryMatch(field, YEAR_PATTERN, match -> builder.year(fromIdentifierToColumn(match.group(1)))) ||
                 tryMatch(field, MONTH_PATTERN, match -> builder.month(fromIdentifierToColumn(match.group(1)))) ||
                 tryMatch(field, DAY_PATTERN, match -> builder.day(fromIdentifierToColumn(match.group(1)))) ||
                 tryMatch(field, HOUR_PATTERN, match -> builder.hour(fromIdentifierToColumn(match.group(1)))) ||
                 tryMatch(field, BUCKET_PATTERN, match -> builder.bucket(fromIdentifierToColumn(match.group(1)), parseInt(match.group(2)))) ||
                 tryMatch(field, TRUNCATE_PATTERN, match -> builder.truncate(fromIdentifierToColumn(match.group(1)), parseInt(match.group(2)))) ||
-                tryMatch(field, VOID_PATTERN, match -> builder.alwaysNull(fromIdentifierToColumn(match.group(1)))) ||
-                false;
+                tryMatch(field, VOID_PATTERN, match -> builder.alwaysNull(fromIdentifierToColumn(match.group(1))));
         if (!matched) {
             throw new IllegalArgumentException("Invalid partition field declaration: " + field);
         }

diff --git a/plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/OracleDataTypes.java b/plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/OracleDataTypes.java
@@ -29,7 +29,6 @@ public final class OracleDataTypes
 {
     private OracleDataTypes() {}
 
-    @SuppressWarnings("MisusedWeekYear")
     public static DataType<ZonedDateTime> oracleTimestamp3TimeZoneDataType()
     {
         return dataType(

diff --git a/...no-raptor-legacy/src/test/java/io/trino/plugin/raptor/legacy/BaseRaptorConnectorTest.java b/...no-raptor-legacy/src/test/java/io/trino/plugin/raptor/legacy/BaseRaptorConnectorTest.java
@@ -782,7 +782,6 @@ public void testTablesSystemTable()
         assertEquals(computeActual("SELECT * FROM system.tables WHERE table_schema IN ('foo', 'bar')").getRowCount(), 0);
     }
 
-    @SuppressWarnings("OverlyStrongTypeCast")
     @Test
     public void testTableStatsSystemTable()
     {

diff --git a/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestWindowQueries.java b/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestWindowQueries.java
@@ -290,7 +290,6 @@ public void testWindowFunctionWithImplicitCoercion()
         assertQuery("SELECT *, 1.0 * sum(x) OVER () FROM (VALUES 1) t(x)", "SELECT 1, 1.0");
     }
 
-    @SuppressWarnings("PointlessArithmeticExpression")
     @Test
     public void testWindowFunctionsExpressions()
     {

diff --git a/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java b/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
@@ -60,7 +60,6 @@ public abstract class BaseConnectorSmokeTest
 
     /**
      * Make sure to group related behaviours together in the order and grouping they are declared in {@link TestingConnectorBehavior}.
-     * If required, annotate the method with {@code @SuppressWarnings("DuplicateBranchesInSwitch")}.
      */
     protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
     {

diff --git a/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java b/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
@@ -206,7 +206,6 @@ protected MockConnectorPlugin buildMockConnectorPlugin()
 
     /**
      * Make sure to group related behaviours together in the order and grouping they are declared in {@link TestingConnectorBehavior}.
-     * If required, annotate the method with {@code @SuppressWarnings("DuplicateBranchesInSwitch")}.
      */
     protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -268,7 +268,6 @@ public boolean isNull(int field) @@
             }
         }
-        @SuppressWarnings("UnusedDeclaration")
         @Override
         public void close()
         {
@@ Expand Down @@