Skip to content

Commit

Permalink
Add write_hive_metastore_recording procedure
Browse files Browse the repository at this point in the history
The procedure will cause Hive metastore recording
to be written. This is more user friendly than JMX endpoint.
  • Loading branch information
sopel39 committed Jan 25, 2019
1 parent b9a1a7e commit 9305d99
Show file tree
Hide file tree
Showing 2 changed files with 73 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.prestosql.plugin.hive.metastore;

import com.google.common.collect.ImmutableList;
import com.google.common.util.concurrent.RateLimiter;
import io.prestosql.spi.procedure.Procedure;

import javax.inject.Inject;
import javax.inject.Provider;

import java.io.IOException;
import java.lang.invoke.MethodHandle;

import static io.prestosql.spi.block.MethodHandleUtil.methodHandle;
import static java.util.Objects.requireNonNull;

public class WriteHiveMetastoreRecordingProcedure
implements Provider<Procedure>
{
private static final MethodHandle WRITE_HIVE_METASTORE_RECORDING = methodHandle(
WriteHiveMetastoreRecordingProcedure.class,
"writeHiveMetastoreRecording");

private final RateLimiter rateLimiter = RateLimiter.create(0.2);
private final RecordingHiveMetastore recordingHiveMetastore;

@Inject
public WriteHiveMetastoreRecordingProcedure(RecordingHiveMetastore recordingHiveMetastore)
{
this.recordingHiveMetastore = requireNonNull(recordingHiveMetastore, "recordingHiveMetastore is null");
}

@Override
public Procedure get()
{
return new Procedure(
"system",
"write_hive_metastore_recording",
ImmutableList.of(),
WRITE_HIVE_METASTORE_RECORDING.bindTo(this));
}

public void writeHiveMetastoreRecording()
{
try {
// limit rate of recording dumps to prevent IO and Presto saturation
rateLimiter.acquire();
recordingHiveMetastore.writeRecording();
}
catch (IOException ex) {
throw new RuntimeException(ex);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,18 @@

import com.google.inject.Binder;
import com.google.inject.Scopes;
import com.google.inject.multibindings.Multibinder;
import io.airlift.configuration.AbstractConfigurationAwareModule;
import io.prestosql.plugin.hive.ForCachingHiveMetastore;
import io.prestosql.plugin.hive.ForRecordingHiveMetastore;
import io.prestosql.plugin.hive.HiveClientConfig;
import io.prestosql.plugin.hive.metastore.CachingHiveMetastore;
import io.prestosql.plugin.hive.metastore.ExtendedHiveMetastore;
import io.prestosql.plugin.hive.metastore.RecordingHiveMetastore;
import io.prestosql.plugin.hive.metastore.WriteHiveMetastoreRecordingProcedure;
import io.prestosql.spi.procedure.Procedure;

import static com.google.inject.multibindings.Multibinder.newSetBinder;
import static io.airlift.configuration.ConfigBinder.configBinder;
import static org.weakref.jmx.guice.ExportBinder.newExporter;

Expand All @@ -49,6 +53,9 @@ protected void setup(Binder binder)
.in(Scopes.SINGLETON);
binder.bind(RecordingHiveMetastore.class).in(Scopes.SINGLETON);
newExporter(binder).export(RecordingHiveMetastore.class);

Multibinder<Procedure> procedures = newSetBinder(binder, Procedure.class);
procedures.addBinding().toProvider(WriteHiveMetastoreRecordingProcedure.class).in(Scopes.SINGLETON);
}
else {
binder.bind(ExtendedHiveMetastore.class)
Expand Down

0 comments on commit 9305d99

Please sign in to comment.