Skip to content

Commit

Permalink
Remove legacy ORC writer identification
Browse files Browse the repository at this point in the history
  • Loading branch information
findepi committed Feb 25, 2022
1 parent 9d30624 commit 8c59033
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ public enum WriterIdentification
*/
LEGACY_HIVE_COMPATIBLE,

/**
* Write ORC files with the legacy writer identification of PrestoSQL
*/
PRESTO,

/**
* Write ORC files with Trino writer identification.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ public class OrcMetadataWriter

// see https://github.com/trinodb/orc-protobuf/blob/master/src/main/protobuf/orc_proto.proto
public static final int PRESTO_WRITER_ID = 2;
// in order to change this value, the master Apache ORC proto file must be updated
private static final int PRESTO_WRITER_VERSION = 6;

// maximum version readable by Hive 2.x before the ORC-125 fix
private static final int HIVE_LEGACY_WRITER_VERSION = 4;
Expand Down Expand Up @@ -99,8 +97,6 @@ private int getOrcWriterVersion()
switch (writerIdentification) {
case LEGACY_HIVE_COMPATIBLE:
return HIVE_LEGACY_WRITER_VERSION;
case PRESTO:
return PRESTO_WRITER_VERSION;
case TRINO:
return TRINO_WRITER_VERSION;
}
Expand Down Expand Up @@ -160,11 +156,6 @@ private void setWriter(OrcProto.Footer.Builder builder)
switch (writerIdentification) {
case LEGACY_HIVE_COMPATIBLE:
return;

case PRESTO:
builder.setWriter(PRESTO_WRITER_ID);
return;

case TRINO:
builder.setWriter(TRINO_WRITER_ID);
return;
Expand Down

0 comments on commit 8c59033

Please sign in to comment.