Rename security NONE to ALLOW_ALL

This is safe change as it is default value. Using ALLOW_ALL makes atop connector to be coherent with other connectors like hive.
trinodb · Nov 3, 2021 · 872ac9b · 872ac9b
1 parent d7c932f
commit 872ac9b
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/plugin/trino-atop/src/main/java/io/trino/plugin/atop/AtopConnectorConfig.java b/plugin/trino-atop/src/main/java/io/trino/plugin/atop/AtopConnectorConfig.java
@@ -30,13 +30,13 @@ public class AtopConnectorConfig
 {
     public enum AtopSecurity
     {
-        NONE,
+        ALLOW_ALL,
         FILE,
     }
 
     private String executablePath = "atop";
     private String timeZone = ZoneId.systemDefault().getId();
-    private AtopSecurity security = AtopSecurity.NONE;
+    private AtopSecurity security = AtopSecurity.ALLOW_ALL;
     private Duration readTimeout = new Duration(5, MINUTES);
     private int concurrentReadersPerNode = 1;
     private int maxHistoryDays = 30;

diff --git a/plugin/trino-atop/src/main/java/io/trino/plugin/atop/AtopConnectorFactory.java b/plugin/trino-atop/src/main/java/io/trino/plugin/atop/AtopConnectorFactory.java
@@ -70,7 +70,7 @@ public Connector create(String catalogName, Map<String, String> requiredConfig,
                     new CatalogNameModule(catalogName),
                     conditionalModule(
                             AtopConnectorConfig.class,
-                            config -> config.getSecurity() == AtopSecurity.NONE,
+                            config -> config.getSecurity() == AtopSecurity.ALLOW_ALL,
                             new AllowAllAccessControlModule()),
                     conditionalModule(
                             AtopConnectorConfig.class,

diff --git a/plugin/trino-atop/src/test/java/io/trino/plugin/atop/TestAtopConnectorConfig.java b/plugin/trino-atop/src/test/java/io/trino/plugin/atop/TestAtopConnectorConfig.java
@@ -37,7 +37,7 @@ public void testDefaults()
         assertRecordedDefaults(recordDefaults(AtopConnectorConfig.class)
                 .setExecutablePath("atop")
                 .setConcurrentReadersPerNode(1)
-                .setSecurity(AtopSecurity.NONE)
+                .setSecurity(AtopSecurity.ALLOW_ALL)
                 .setReadTimeout(new Duration(5, MINUTES))
                 .setMaxHistoryDays(30)
                 .setTimeZone(TimeZone.getDefault().getID()));

diff --git a/...no-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/security/RaptorSecurity.java b/...no-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/security/RaptorSecurity.java
@@ -15,7 +15,7 @@
 
 public enum RaptorSecurity
 {
-    NONE,
+    ALLOW_ALL,
     FILE,
     READ_ONLY,
 }
diff --git a/...tor-legacy/src/main/java/io/trino/plugin/raptor/legacy/security/RaptorSecurityConfig.java b/...tor-legacy/src/main/java/io/trino/plugin/raptor/legacy/security/RaptorSecurityConfig.java
@@ -19,7 +19,7 @@
 
 public class RaptorSecurityConfig
 {
-    private RaptorSecurity securitySystem = RaptorSecurity.NONE;
+    private RaptorSecurity securitySystem = RaptorSecurity.ALLOW_ALL;
 
     @NotNull
     public RaptorSecurity getSecuritySystem()

diff --git a/...tor-legacy/src/main/java/io/trino/plugin/raptor/legacy/security/RaptorSecurityModule.java b/...tor-legacy/src/main/java/io/trino/plugin/raptor/legacy/security/RaptorSecurityModule.java
@@ -21,8 +21,8 @@
 import io.trino.plugin.base.security.ReadOnlySecurityModule;
 
 import static io.airlift.configuration.ConditionalModule.conditionalModule;
+import static io.trino.plugin.raptor.legacy.security.RaptorSecurity.ALLOW_ALL;
 import static io.trino.plugin.raptor.legacy.security.RaptorSecurity.FILE;
-import static io.trino.plugin.raptor.legacy.security.RaptorSecurity.NONE;
 import static io.trino.plugin.raptor.legacy.security.RaptorSecurity.READ_ONLY;
 
 public class RaptorSecurityModule
@@ -31,7 +31,7 @@ public class RaptorSecurityModule
     @Override
     protected void setup(Binder binder)
     {
-        bindSecurityModule(NONE, new AllowAllAccessControlModule());
+        bindSecurityModule(ALLOW_ALL, new AllowAllAccessControlModule());
         bindSecurityModule(READ_ONLY, new ReadOnlySecurityModule());
         bindSecurityModule(FILE, new FileBasedAccessControlModule());
     }

diff --git a/...legacy/src/test/java/io/trino/plugin/raptor/legacy/security/TestRaptorSecurityConfig.java b/...legacy/src/test/java/io/trino/plugin/raptor/legacy/security/TestRaptorSecurityConfig.java
@@ -21,7 +21,7 @@
 import static io.airlift.configuration.testing.ConfigAssertions.assertFullMapping;
 import static io.airlift.configuration.testing.ConfigAssertions.assertRecordedDefaults;
 import static io.airlift.configuration.testing.ConfigAssertions.recordDefaults;
-import static io.trino.plugin.raptor.legacy.security.RaptorSecurity.NONE;
+import static io.trino.plugin.raptor.legacy.security.RaptorSecurity.ALLOW_ALL;
 import static io.trino.plugin.raptor.legacy.security.RaptorSecurity.READ_ONLY;
 
 public class TestRaptorSecurityConfig
@@ -30,7 +30,7 @@ public class TestRaptorSecurityConfig
     public void testDefaults()
     {
         assertRecordedDefaults(recordDefaults(RaptorSecurityConfig.class)
-                .setSecuritySystem(NONE));
+                .setSecuritySystem(ALLOW_ALL));
     }
 
     @Test