Function to_utf8 supports char type

trinodb · Jan 2, 2024 · 870d9e4 · 870d9e4
1 parent 5912370
commit 870d9e4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/operator/scalar/StringFunctions.java b/core/trino-main/src/main/java/io/trino/operator/scalar/StringFunctions.java
@@ -30,6 +30,7 @@
 import io.trino.spi.function.ScalarOperator;
 import io.trino.spi.function.SqlNullable;
 import io.trino.spi.function.SqlType;
+import io.trino.spi.type.Chars;
 import io.trino.spi.type.StandardTypes;
 import io.trino.type.CodePointsType;
 import io.trino.type.Constraint;
@@ -880,6 +881,15 @@ public static Slice toUtf8(@SqlType("varchar(x)") Slice slice)
         return slice;
     }
 
+    @Description("Encodes the string to UTF-8")
+    @ScalarFunction
+    @LiteralParameters("x")
+    @SqlType(StandardTypes.VARBINARY)
+    public static Slice toUtf8(@LiteralParameter("x") long x, @SqlType("char(x)") Slice slice)
+    {
+        return Chars.padSpaces(slice, (int) x);
+    }
+
     // TODO: implement N arguments char concat
     @Description("Concatenates given character strings")
     @ScalarFunction

diff --git a/core/trino-main/src/test/java/io/trino/operator/scalar/TestStringFunctions.java b/core/trino-main/src/test/java/io/trino/operator/scalar/TestStringFunctions.java
@@ -2240,6 +2240,10 @@ public void testFromUtf8()
                 .hasType(VARCHAR)
                 .isEqualTo("hello");
 
+        assertThat(assertions.function("from_utf8", "to_utf8(cast('hello' as char(10)))"))
+                .hasType(VARCHAR)
+                .isEqualTo("hello     ");
+
         assertThat(assertions.function("from_utf8", "from_hex('58BF')"))
                 .hasType(VARCHAR)
                 .isEqualTo("X\uFFFD");
@@ -2269,6 +2273,12 @@ public void testFromUtf8()
 
         assertTrinoExceptionThrownBy(assertions.function("from_utf8", "to_utf8('hello')", "1114112")::evaluate)
                 .hasErrorCode(INVALID_FUNCTION_ARGUMENT);
+
+        assertTrinoExceptionThrownBy(assertions.function("from_utf8", "to_utf8(cast('hello' as char(10)))", "'foo'")::evaluate)
+                .hasErrorCode(INVALID_FUNCTION_ARGUMENT);
+
+        assertTrinoExceptionThrownBy(assertions.function("from_utf8", "to_utf8(cast('hello' as char(10)))", "1114112")::evaluate)
+                .hasErrorCode(INVALID_FUNCTION_ARGUMENT);
     }
 
     @Test